Problem/Motivation
One thing that is bugging me every time I install Drupal 8 (thanks for the shiny new design! loving it):
the progress bar goes much too far to the right:
This is probably just an oversight. The right padding should at least match the padding the page has on the left. I noticed that not only the progress bar, but everything is too far to the right.
Proposed resolution
Just match the right padding to the left padding.
I gave body.install-page #page a right-padding of 3.5 em and made the entire container a bit narrower (740px instead of 770) so it remains about the same width.
As the progress bar still does not look right with this, I gave it a further 2em margin to the right.
So that's my initial patch. Patch uploaded in first comment, as without posting the issue first, there is no issue number.
Comment | File | Size | Author |
---|---|---|---|
#14 | 2094445-before.png | 1.01 MB | LewisNyman |
#14 | 2094445-after.png | 1013.72 KB | LewisNyman |
#13 | drupalcore_fixinstallercss_2094445_12.patch | 869 bytes | Outi |
#12 | drupalcore_fixinstallercss_2094445_12.patch | 869 bytes | Outi |
#9 | drupalcore_fixinstallercss_2094445_9.patch | 787 bytes | Outi |
Comments
Comment #1
eigentor CreditAttribution: eigentor commentedComment #3
LewisNyman CreditAttribution: LewisNyman commentedComment #4
LewisNyman CreditAttribution: LewisNyman commentedI also noticed this vertical spacing issue when the page takes up the height of the viewport. There should be some blue spacing before and after the white container. It would be good to fix it here.
Comment #5
Outi CreditAttribution: Outi commentedThe patch should set the margins and paddings in a symmetric way and add a margin on the top and the bottom of the page.
Comment #6
pameeela CreditAttribution: pameeela commentedLooks good.
Screenshot:
Comment #7
LewisNyman CreditAttribution: LewisNyman commentedAh, just noticed that the container is no longer centered...
Comment #8
LewisNyman CreditAttribution: LewisNyman commentedAfter some discussion and head bashing, I think it's best to deal with the vertical padding separately and simply fix the right padding issue in this patch.
Comment #9
Outi CreditAttribution: Outi commentedI removed the lines I added or changed on the last patch while trying to add some space between the top and the bottom of the white container and the navigator window.
Comment #10
Outi CreditAttribution: Outi commentedComment #11
LewisNyman CreditAttribution: LewisNyman commentedWe also need to change the RTL styling now that we've changed the LTR
Comment #12
Outi CreditAttribution: Outi commentedComment #13
Outi CreditAttribution: Outi commentedComment #14
LewisNyman CreditAttribution: LewisNyman commentedLooks good! Here are some before/after screenshots:
Comment #15
eigentor CreditAttribution: eigentor commentedO.K. this fixes the vertical margin issue, but leaves out the stuff why I originally created the issue...-- edit --
Or maybe not.
I'll have a look at the patch first.
Comment #16
eigentor CreditAttribution: eigentor commentedO.K. my bad, fixes the right padding issue.
Can't see any change on vertical margin, though.
http://screencast.com/t/CAQ8JwNlFTBh
Did this get lost, or would it be another issue?
Keeping things incremental would be in favor of creating another issue for it.
Comment #17
LewisNyman CreditAttribution: LewisNyman commentedYeah let's deal with it in another issue, I think the best action is to re-open #2032895: Follow-up use better technique for vertical centering
Comment #18
webchickCommitted and pushed to 8.x. Thanks!