Remove instances of menu_get_object('taxonomy_term')

From the original issue, this one instance:

menu_get_object() is breaking (fatal error) taxonomy_term_is_page() if the core taxonomy/term/% page view is enabled (views.view.taxonomy_term.yml).

To reproduce, add content in terms. Enable view. Clear cache. Then $request->attributes->get(RouteObjectInterface::ROUTE_OBJECT)->getPath(); returns NULL. Hence taxonomy_term_is_page() tries to access id on non-object $page_term.

Something as simple as attached?

 function taxonomy_term_is_page(Term $term) {
-  $page_term = menu_get_object('taxonomy_term', 2);
-  return (!empty($page_term) ? $page_term->id() == $term->id() : FALSE);
+  $page_term = \Drupal::request()->attributes->get('taxonomy_term');
+  return (is_object($page_term) && $page_term instanceof Term ? $page_term->id() == $term->id() : FALSE);

Following suggestion in irc from timplunkett.

 function taxonomy_term_is_page(Term $term) {
-  $page_term = menu_get_object('taxonomy_term', 2);
-  return (!empty($page_term) ? $page_term->id() == $term->id() : FALSE);
+  $request = \Drupal::request();
+  if ($request->attributes->has('taxonomy_term')) {
+    $page_term = $request->attributes->get('taxonomy_term');
+    return $page_term->id() == $term->id();
+  }
+  return FALSE;
 }

#3: menu_get_object.2095971-03.patch queued for re-testing.