The module allows you to import comments from a Disqus service to native comments Drupal.
If you want to migrate from Disqus comments to Drupal native comments, this module form you.
The module allows you to select the file from which you want to export the comment, select comment body format and select formation for comments title.
Sandbox link: https://drupal.org/sandbox/sanchiz/1999128
Git repository: http://drupalcode.org/sandbox/sanchiz/1999128.git
Drupal Version: 7.x
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/sanchiz/1999128.git disqus_import
Reviews of other projects
1. Ubercart Paymill Integration (module)
https://drupal.org/node/2095819#comment-7894585
2. Contentaccess Roles (module)
https://drupal.org/node/2077293#comment-7933087
3. Save Redirect On Delete
https://drupal.org/comment/8558735#comment-8558735
Comments
Comment #1
PA robot CreditAttribution: PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #1.0
PA robot CreditAttribution: PA robot commentedAdd drupal version.
Comment #2
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxsanchiz1999128git
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
sanchiz CreditAttribution: sanchiz commentedFixed all warnings and errors.
Comment #4
Enxebre CreditAttribution: Enxebre commentedHi,
I see you are calling "variable_get('disqus_domain', '')" in "disqus_import.admin.inc" line 26 but I am no able to see where do you set this variable.
Have you considered to use the migrate API for this? I don´t know the Third party API services but It seems like a good choice. https://drupal.org/project/migrate
Regards
Comment #5
sanchiz CreditAttribution: sanchiz commentedThanks for review!
The variable disqus_domain setup by module Disqus, if variable is exist, in admin page you will receive link import.disqus.com with domain to your project, example import.disqus.com/disqus.com, if module Disqus is disabled, you will receive link import.disqus.com.
I think using Mirgate API this is good idea, but Disqus Import this is simple little project, provide easy way to migrate from Disqus.
Comment #5.0
sanchiz CreditAttribution: sanchiz commentedAdded reviewed module.
Comment #5.1
sanchiz CreditAttribution: sanchiz commentedChange branch.
Comment #6
rameshrasaiyan CreditAttribution: rameshrasaiyan commentedHi sanchiz,
I am getting the following notice and warnings if I do not upload the Disqus import XML file and click Import. So please validate that Import File field and display the message, if the XML file has not been uploaded.
Thanks,
Ramesh
Comment #7
sanchiz CreditAttribution: sanchiz commentedThanks for review, Ramesh
Fixed validation. Changed status to need review.
Comment #8
vijaycs85Thanks for working on this module. Here is some manual review comments:
1. Some tips from pareview.sh - There is still a master branch, make sure to set the correct default branch: [#1659588] . Then remove the master branch, see also step 6 and 7 in [#1127732]
2.
$form_state['values']['file'] = $file;
- Seems this is not used anywhere in _submit(). Do we really need it form_state?3. There is no .test to cover the functionalities of this module.
4.
if (node_load($comment->nid)) {
- if we are going to load N number of comments, we do N node_load to just see if nid is a valid node ID or not. For performance point of view, can we have a helper that just select nid from node and keep static cache, etc so that we don't need to load same node for multiple comments?5.
in _submit function. We may need to replace with form_state['redirect'] just leave it. Is there any reason to return it?
Comment #8.0
vijaycs85Added review.
Comment #9
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #10
sanchiz CreditAttribution: sanchiz commentedAdded test. Fixed all wishes. Needs review. Thanks!
Comment #11
sanchiz CreditAttribution: sanchiz commentedAdded review.
Comment #12
sanchiz CreditAttribution: sanchiz commentedAdded review bonus tag.
Comment #13
klausiThe existing disqus module already has the import functionality. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the disqus issue queue to discuss what you need in addition. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.
If that fails for whatever reason please get back to us and set this back to "needs review".
Comment #14
sanchiz CreditAttribution: sanchiz commentedHi klausi! Thanks for review and explanation.
When I started development of module such functionality has not yet been in Disqus. Now my module is redundant, I agree.
My entreaty it's give me full access project. Now I won't promote my module to full project, but I need full access project for my drupal distributive.
I make enough contribution to Drupal and I think you can help me with full access project. Also I participated in drupal.org improvements https://drupal.org/node/2159813 and contributed to some modules.
If you can give me full access project I will be happy to contribute to Drupal! Thanks!
Comment #15
klausiPlease open a new project application when you need to promote a new project. It only makes sense to approve you as git vetted user when there is new code that is actually going to be promoted to a full project. Otherwise it is a bit of waste of time for reviewers.
Don't let that discourage you, you can already contribute to Drupal in many ways. Make sure to re-use your review bonus on the next application and I will be happy to review it!
Comment #16
apaderno