Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
@chx seems to have added this, but why don't we use it?
Comment | File | Size | Author |
---|---|---|---|
#8 | 1901390_8.patch | 940 bytes | chx |
drupal8.annotation-only.0.patch | 1.8 KB | sun | |
Comments
Comment #1
EclipseGc CreditAttribution: EclipseGc commentedThis has to be done upstream in Doctrine. Do we need this for the change in AnnotatedClassDiscovery?
Comment #2
chx CreditAttribution: chx commentedwat? I ack the bug that $className needs to be $this->className (needs to be fixed upstream) but since when does a php identifier need a preg_quote??
Comment #3
chx CreditAttribution: chx commentedThis has been fixed upstream about one day before sun filed this issue.
Comment #4
sunThe primary and essential change in question is only this anyway:
Was there any particular reason for not using the option?
Comment #5
chx CreditAttribution: chx commentedNone but we need the commit i linked before we can use it cos *blush* it's broken in the current version core has.
Comment #6
jibrandrupal8.annotation-only.0.patch queued for re-testing.
Comment #8
chx CreditAttribution: chx commentedComment #9
chx CreditAttribution: chx commentedI have only rerolled #0 really w/o the Doctrine change -- and I know this works :)
Comment #10
neclimdulSeems reasonable. To be clear because I was confused, we already pulled in the other changes so we just need to turn on the optimization. I can't see a problem with that its pretty straightforward and if you're following our standards there won't be a problem.
RTBC+1
Comment #11
alexpottCommitted 47ff5ff and pushed to 8.x. Thanks!