Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This is the code in user.module:
function user_view_multiple($accounts, $view_mode = 'full', $langcode = NULL) {
return entity_view($accounts, $view_mode, $langcode);
}
it muse use entity_view_multiple() instead of entity_view().
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 2097437-1-user-view-multiple.patch | 546 bytes | Jelle_S |
Comments
Comment #1
Jelle_SPatch
Comment #2
BerdirThanks. I'm not sure if we even want to keep this, probably not? Did we remov other view methods when converting to use routes?
Comment #3
Jelle_SI did a search through drupal core (just netbeans right-click -> find, no fancy grep ;-) ) and did not find any usages of user_view_multiple. We might just delete it in favour of entity_view_multiple. But then again, there's also node_view_multiple (which is used in node_show and taxonomy_term_page.
Comment #4
BerdirYes, and node_show() and taxonomy_term_page() will go away when they are property converted to controller classes, which don't need any wrapper functions anymore, there's a default controller to display an entity.
Comment #5
Jelle_SAh, I see...
Do we need to create separate issues for removing *_view_multiple() functions, and add them to the list in #1971384: [META] Convert page callbacks to controllers?
[EDIT]
Come to think of it, *_view functions should be removed as well then?
Comment #6
catchI think we should remove this, but until then I'm happy to commit this as is.
Comment #7
catchCommitted/pushed to 8.x, thanks! Just a one-liner to fix already dead code so ignoring my usual 24+ hour time from RTBC.