Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The test block appears in the custom category.
Other
DisplayBlockTest.php
102
Drupal\block\Tests\Views\DisplayBlockTest->testBlockCategory()
The second cloned test block appears in the custom category.
Other
DisplayBlockTest.php
120
Drupal\block\Tests\Views\DisplayBlockTest->testBlockCategory()
Comment | File | Size | Author |
---|---|---|---|
#15 | drupal-2097537-15.patch | 4.78 KB | olli |
#15 | interdiff.txt | 1.65 KB | olli |
#12 | 2097537-12-random-fail.patch | 816 bytes | olli |
#12 | 2097537-12-random-pass.patch | 3.6 KB | olli |
#12 | drupal-2097537-12.patch | 3.13 KB | olli |
Comments
Comment #1
tim.plunkettTagging.
Comment #2
tim.plunkettFrom form_builder():
The implode is causes any leading or trailing hyphens to be stripped off before making the ID.
Comment #3
tim.plunkettMarking this critical because it just "broke" HEAD.
Comment #4
tim.plunkettNevermind, that last assumption was completely wrong, and idk why I thought that. It's just that drupal_html_id() removes consecutive hyphens.
Comment #5
pwolanin CreditAttribution: pwolanin commentedper IRC discussion - that's the wrong fix, instead move
'edit-' .
inside the call to drupal_html_id($id)Comment #6
pwolanin CreditAttribution: pwolanin commentedcross-post - yes, #4 looks like the right fix.
Comment #7
pwolanin CreditAttribution: pwolanin commentedI'm not sure that the String::checkPlain() is actually needed, but clearly it's already in the test.
Comment #8
pwolanin CreditAttribution: pwolanin commentedRTBC (assuming the tests pass with the corrected logic).
Comment #9
jibranFinally @tim.plunkett created the issue :P. RTBC +1
Comment #10
alexpottCommitted 34f638b and pushed to 8.x. Thanks!
Comment #11
tim.plunkettBerdir found yet another random fail in the same place, but much less common...
Comment #12
olli CreditAttribution: olli commentedCategories like "#random" are not visible on the block placement page.
Comment #15
olli CreditAttribution: olli commentedComment #16
tim.plunkettThanks... This has been awful :)
Comment #17
webchickWow, great find!
Committed and pushed to 8.x. Thanks!