We are still using Chosen 1.x, which is not even supported anymore. The currently supported release is 2.x-alpha2, and it also fixes #1837632: Warnings when trying to edit a price field.
So let's move to 2.x-alpha2 and test Kickstart with it.

Comments

makokis’s picture

makokis CreditAttribution: makokis commented

did you mean to delete the "chosen 1.x contribution module", and install the new chosen 2.x in:
site/all/modules ?

thanks

jsacksick’s picture

jsacksick CreditAttribution: jsacksick commented

I wanted to do that, but afair there was an issue that wasn't fixed in the 2.x branch but the update seemed to work when I tried it.

dudenhofer’s picture

dudenhofer CreditAttribution: dudenhofer commented

I tested this as well and the update seemed to work fine. We will need to make some theme updates to maintain some of the select box styles, though.

jsacksick’s picture

jsacksick CreditAttribution: jsacksick commented
Issue summary: View changes
Status: Active » Needs review

I opened a Pull request for that (https://github.com/commerceguys/commerce_kickstart/pull/3/files), however it needs some css love before it gets in. Aaron, we need your skills now :)

jsacksick’s picture

jsacksick CreditAttribution: jsacksick commented
Assigned: Unassigned » dudenhofer
balintk’s picture

balintk CreditAttribution: balintk commented
Status: Needs review » Needs work
lsolesen’s picture

lsolesen CreditAttribution: lsolesen commented

I started a new pull request. https://github.com/commerceguys/commerce_kickstart/pull/39

Anybody remembers exactly where to test it in the CK 2.x distro?

dudenhofer’s picture

dudenhofer CreditAttribution: dudenhofer commented
Status: Needs work » Needs review

I pushed a commit to unify the styles between both 1.x and 2.x in Shiny here:
http://drupalcode.org/project/shiny.git/commit/6b68b49

To test, visit the products or orders admin pages - the views filters should all use the chosen selectors (and with the latest shiny dev look the same between the 2 versions).

lsolesen’s picture

lsolesen CreditAttribution: lsolesen commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit d0f6f70 on 7.x-2.x by bojanz: 
    Merge pull request #39 from lsolesen/chosen-2.x

Issue #2073309 by...
  • Commit d60d47c on 7.x-2.x by lsolesen:
    Issue #2073309 by bojanz: Move to chosen 2.x