Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
We need to add hasConfigSchema method.
Proposed resolution
Issue patch!!!
Remaining tasks
User interface changes
API changes
Related Issues
Comment | File | Size | Author |
---|---|---|---|
#13 | 2097259-has-config-schema-13.patch | 3.45 KB | vijaycs85 |
#13 | 2097259-diff-12-13.txt | 496 bytes | vijaycs85 |
#12 | 2097259-has-config-schema-12.patch | 3.43 KB | vijaycs85 |
#12 | 2097259-diff-9-12.txt | 1.96 KB | vijaycs85 |
#9 | 2097259-has-config-schema-9.patch | 2.37 KB | tstoeckler |
Comments
Comment #1
vijaycs85Initial patch...
Comment #2
vijaycs85Few documentation improvements as per @tstoeckler.
Comment #3
tstoecklerAwesome, thanks @vijaycs85!
Also tagging this as blocker. We currently have this as a procedural method in config_translation but A) this is in no way specific to config_translation and B) procedural function --
So let's get this out of the way.
Comment #4
Gábor HojtsyYou know this needs tests. A simple one checking a config schema that does not exist and one that does would be great. I think we may have in fact some test for a similar thing that can be extended.
Comment #5
tstoecklerYeah, I guess tests can't hurt. And it was especially easy with your help! Thanks again.
Comment #6
tstoecklerOh yeah, that is not really necessary, but I hate to stare at something for 5 seconds until I grok it, and I think it's clearer this way.
Comment #8
tstoecklerThat's embarassing. As soon as there's no autocompletion, I get 3 fatals for 3 LoC.
Comment #9
tstoecklerDamn, I really need some sleep. The interdiff is correct, but this should have been the patch. #8 is identical to #5.
Comment #10
Gábor HojtsyComment #11
alexpottLets create a TypedConfigManagerInterface as we're adding a public method to an object.
Comment #12
vijaycs85Thanks for the review @alexpott. Here is the interface with Manager update.
Comment #13
vijaycs85Minor doc comment update...
Comment #14
Gábor HojtsyYay! Resolves the above concerns :)
Comment #16
vijaycs85#13: 2097259-has-config-schema-13.patch queued for re-testing.
Comment #17
vijaycs85Back to RTBC as per @Gábor Hojtsy at #14
Comment #18
webchickCommitted and pushed to 8.x. Thanks!