Updated: Comment 8
Problem/Motivation
During the development of the action module the config entity moved from the action module to the system module. However the config entity prefix is still action.action. This means that if you uninstall the action module and have views enabled you will suddenly lose functionality on admin/people
.
Steps to reproduce:
- Enable views and action module
- Disable and uninstall action module
- Try to block user using the bulk operation form on admin/people
Proposed resolution
- Change action config entity to system.action
- Rename actions provided modules to system.action
- We need to decide what to do about the custom actions created by the action module
Remaining tasks
Everything
User interface changes
N/a
API changes
Change in the config entity prefix from action.acton
to system.action
Related Issues
This was discovered whilst working on #1776830: [META-1] Installation and uninstallation of configuration provided by a module that belongs to another module's API
Comment | File | Size | Author |
---|---|---|---|
#6 | 3-6-interdiff.txt | 800 bytes | alexpott |
#6 | 2082499.6.patch | 7.22 KB | alexpott |
#3 | 2082499.3.patch | 7.13 KB | alexpott |
#2 | 2082499.2.will_.fail_.patch | 1.54 KB | alexpott |
Comments
Comment #1
alexpottTagging up
Comment #2
alexpottHere's a test that indicates we have a problem
Comment #3
alexpottAnd here's a patch that:
Comment #5
tim.plunkettYou have to provide a message here, or simpletest will try to var_export the whole entity.
Comment #6
alexpottGood point.
Comment #7
tim.plunkettThis is perfect, thanks!
We should consider renaming action.module to action_ui.module, it might have helped catch our naming mistake earlier. It is similar to field_ui and views_ui, in that everything still works when it is disabled/uninstalled.
Comment #8
alexpottDue to #7 opened #2083649: Rename action module to action_ui
Comment #9
catchCommitted/pushed to 8.x
Will need a change notice.
Comment #10
mtiftI created https://drupal.org/node/2084169.
Comment #11
tim.plunkettComment #12
tim.plunkettI updated https://drupal.org/node/2020549/revisions/view/2730703/2833053. Not sure this needed a standalone one, but now there can be no confusion
Comment #13
agentrickardSomething in this change broke the actions in my contrib module. They have been named action.action.foo.yml. Now they are no longer read and loaded by the actions module.
See https://github.com/agentrickard/domain/tree/8.x-1.x/config
The tests here were working until this patch landed. https://github.com/agentrickard/domain/blob/8.x-1.x/lib/Drupal/domain/Te...
So at the least I think the change notice needs some guidance there on what contrib is supposed to do.
Comment #14
catchThe change notice points out the system. prefix - i.e. system.action.comment_unpublish_action.yml
Comment #15
agentrickardSo contrib should use system.action.foo.yml as well?
That is not clear in the change notice.
Comment #16
agentrickardUpdated.
Comment #17
alexpottThanks @agentrickard - the action config entity type is provided by the system module - the action module is just a UI for it.
InformativeChangeNotices++ :)
Comment #18.0
(not verified) CreditAttribution: commentedUpdated issue summary.