The parseDependency method does not belong into the ModuleHandler. It's a general utility thing. And while we are at it we can just as well move the checkIncompatibility method over as well.

CommentFileSizeAuthor
#7 drupal8.base-system.2098521-7.patch11.93 KBfubhy
#1 drupal8.base-system.2098521-1.patch7.85 KBfubhy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fubhy’s picture

fubhy CreditAttribution: fubhy commented
Status: Active » Needs review
FileSize
drupal8.base-system.2098521-1.patch7.85 KB

Status: Needs review » Needs work

The last submitted patch, drupal8.base-system.2098521-1.patch, failed testing.

fubhy’s picture

fubhy CreditAttribution: fubhy commented
Status: Needs work » Needs review

We already got more than enough crap in ModuleHandler so I really want to get rid of this additional burden. I am going to do some further cleanup in a couple of other issues and this would really help to keep that class clean.

fubhy’s picture

fubhy CreditAttribution: fubhy commented

#1: drupal8.base-system.2098521-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, drupal8.base-system.2098521-1.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented

Yes, I agree with this issue. The patch is missing the actual file.

fubhy’s picture

fubhy CreditAttribution: fubhy commented
Status: Needs work » Needs review
FileSize
drupal8.base-system.2098521-7.patch11.93 KB

Yes, I agree with this issue. The patch is missing the actual file.

/facepalm

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Is there a reason why this is not part of the extension namespace at least?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Needs work

.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Issue summary: View changes
Status: Needs work » Fixed

This is now part of the module handler.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.