Updated: Comment #0

Problem/Motivation

For config_translation.module we need a way to check whether a translation exists for a certain config name. This is only related to the locale override system and is not related to the config translation system in particular, so it should not be added there.

Proposed resolution

Add a "hasTranslation()" utility method to LocaleConfigManager.

CommentFileSizeAuthor
#8 2098697-locale-has-translation-8.patch4.56 KBtstoeckler
#8 2098697-locale-has-translation-interdiff-1-8.txt2.4 KBtstoeckler
#6 locale-config-manager-has-translation-2098697-5.patch5.99 KBGábor Hojtsy
#5 locale-config-manager-has-translation-2098697-5.patch5.99 KBsxnc
#1 locale-config-manager-has-translation.patch5.46 KBtstoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Active » Needs review
FileSize
locale-config-manager-has-translation.patch5.46 KB

Here we go.

Status: Needs review » Needs work

The last submitted patch, locale-config-manager-has-translation.patch, failed testing.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: +D8MI, +sprint, +language-config, +blocker

This is a blocker for #2097101: Remove deprecated functions , which is a blocker for #1952394: Add configuration translation user interface module in core.

sxnc’s picture

sxnc CreditAttribution: sxnc commented
Assigned: Unassigned » sxnc
Issue tags: -D8MI, -sprint, -language-config, -blocker
sxnc’s picture

sxnc CreditAttribution: sxnc commented
Status: Needs work » Needs review
Issue tags: +D8MI, +sprint, +language-config, +blocker
FileSize
locale-config-manager-has-translation-2098697-5.patch5.99 KB
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
FileSize
locale-config-manager-has-translation-2098697-5.patch5.99 KB

Re-uploading for testbot sanity. We need it to return data for us.

Status: Needs review » Needs work

The last submitted patch, locale-config-manager-has-translation-2098697-5.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs work » Needs review
FileSize
2098697-locale-has-translation-interdiff-1-8.txt2.4 KB
2098697-locale-has-translation-8.patch4.56 KB

I don't think that #5/#6 are the correct fix.

Gábor explained that there's a problem with empty config files because they get imported and also their schema is getting parsed. This seems to be the problem. I've removed those files. So we can't test the hasTranslation() behavior with empty translation files, but we can't have empty translation files without other stuff failing anyway, so I think that's OK.

Sorry @sxnc for taking this over, hope that's OK.

Let's see if that passes.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Reviewed & tested by the community

Looks good! Reviewed in person.

sxnc’s picture

sxnc CreditAttribution: sxnc commented

@tstoeckler np! i thought i had it fixed but its good to see what the actual problem was, thanks a lot! :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs work

Doesn't seem to apply for me. :(

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs work » Needs review
Issue tags: -D8MI, -sprint, -language-config, -blocker

#8: 2098697-locale-has-translation-8.patch queued for re-testing.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: +D8MI, +sprint, +language-config, +blocker

#8: 2098697-locale-has-translation-8.patch queued for re-testing.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Reviewed & tested by the community

Still applies/passes with the testbot in the past 2 days. @webchick can you try again? :) Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Huh. No idea what that was about.

Committed and pushed to 8.x. Thanks!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: -sprint

Thanks a lot! Woot!

Automatically closed -- issue fixed for 2 weeks with no activity.