This new feature is a huge improvement to many of the admin pages. Thanks + congrats to all who have contributed to this so far.
Can I suggest a couple of enhancements to make it even better:
1. While dragging an item, it's not that easy to see which one you have hold of - the very pale yellow doesn't show up well on my LCD at normal viewing angles. For disabled menu items, with the additional 50% opacity it's even worse. Patch for Garland's style.css and system.css attached, which makes the yellows stronger. I find this much easier to use as I can see what I am dragging much more easily. See attached screenshots also.
2. It would be great if you could somehow cancel a drag operation? ESC or dragging outside the window would be useful ways of doing this ... my JS skills aren't up to proposing a patch though!
Grateful for any comments etc.
[Screenshot naming convention: *-drag.jpg show the colours while the row is being dragged; *-drag-previous.jpg show the colours when the row is dropped. Note also the yellow is now stronger during the drag operation than after it is dropped. This makes sense to me...]
[Reposted from some of http://drupal.org/node/181066#comment-638589.]
Comment | File | Size | Author |
---|---|---|---|
#12 | tabledrag_yellow_201876_12.patch | 245 bytes | gpk |
#2 | tabledrag_yellow_201876_a.patch | 241 bytes | gpk |
new-drag-previous.jpg | 17.02 KB | gpk | |
new-drag.jpg | 17.07 KB | gpk | |
original-drag-previous.jpg | 17.66 KB | gpk |
Comments
Comment #1
quicksketchJust keeping on radar. I think the patch makes sense for system.css (where things are generally pretty ugly anyway), but not so much for Garland. Stefan Nagtegaal (the Garland designer) and I talked it over a few times about the colors used in Garland, but the default color used by other themes was never much debated.
Comment #2
gpk CreditAttribution: gpk commentedOK this is a really tiny patch now.
All it does it make the yellow color slightly stronger while dragging an item in Garland (and Minelli) themes. This makes it much easier to see what you are doing.
Having a paler color while dragging makes sense for the other (older) core themes since these have a grey background for table rows. However, it looks like the same 'drag' color was copied into Garland's style.css without modification. Since the row background color in Garland is white for 'even' rows, the 'drag' color doesn't contrast at all with these.
Too see what the patch does, look at http://drupal.org/files/issues/new-drag-previous.jpg. With the current patch, this is the color *while dragging*.
Some other minor points:
1. Restricting this issue to be just about the "color while dragging" issue.
2. The 'drag-previous' color matches the 'div.warning' color. This clearly makes a lot of sense, so have discarded the proposed change there.
Comment #3
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedI'll look into this soon, but I fail to see why this has got to do anything related to usability..
Stefan
Comment #4
gpk CreditAttribution: gpk commentedThanks ;-)
>why this has got to do anything related to usability..
It just makes it a bit easier to see what you are doing IMO, especially when dragging a menu and its sub-items above or below another menu and its sub-items. And I'd say it makes more sense (in Garland at least) for the color to be slightly stronger while you are dragging.
Comment #5
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedOkay, after some thinking and searching looking around the web it seems you are right.
It does indeed make things a little better when we do have it stand out a little more..
This small patch in #2 is RTBC.
Comment #6
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD.
Comment #7
gpk CreditAttribution: gpk commentedThanks guys for taking the trouble to look into this one :-)
Comment #8
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #9
gpk CreditAttribution: gpk commentedI was wondering why I was having trouble seeing the yellow on the row I was dragging in 6.x admin screens (with Garland as the admin theme) - but #2 was only applied to 7.x.
Tempted to set this to RTBC..
Comment #10
dpearcefl CreditAttribution: dpearcefl commentedIs this still an issue using current Drupal 6?
Comment #12
gpk CreditAttribution: gpk commentedYes, still an issue.
Have hacked the original patch to work with -p1, hope I got it right! Applies with offset -1.
Comment #13
gpk CreditAttribution: gpk commentedSetting to RTBC per #5 and green light from testbot. Has already been applied to 7.x.
Comment #14
dpearcefl CreditAttribution: dpearcefl commentedExcellent! Thanks.
Comment #15
Gábor HojtsyThanks, committed to Drupal 6.