I was trying to wrap my head around this, but I'm pretty sure it's just not needed.

In block.routing.yml, block.admin_display provides an entity_type argument, but BlockListController overrides EntityListController::listing, removing entity_type from the arguments.

I tested by removing the argument and clearing cache. The admin display continued to load fine.

CommentFileSizeAuthor
extra_block_routing_arg.patch445 bytesmmilano
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mmilano’s picture

mmilano CreditAttribution: mmilano commented
Status: Active » Needs review
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix, +Novice

@mmilano thanks nice catch.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Assigned: Unassigned » tim.plunkett

Yes we can do this. However, all other entity list controllers use the entity_type key so I'm not sure we want to do this.

Assigning to Tim for a second opinion.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

+1 for RTBC, that is not needed, and was left over from refactoring.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Assigned: tim.plunkett » Unassigned
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.