Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is fixed and also a lot of code duplication is nuked from KeyValueExpirableFactory.
Comment | File | Size | Author |
---|---|---|---|
#21 | 2098111_21.patch | 13.83 KB | chx |
#19 | 2098111_19.patch | 13.64 KB | chx |
#15 | 2098111_15.patch | 12.3 KB | chx |
#13 | 2098111_13.patch | 12.09 KB | chx |
#13 | interdiff.txt | 2.29 KB | chx |
Comments
Comment #1
chx CreditAttribution: chx commentedComment #3
chx CreditAttribution: chx commentedComment #5
chx CreditAttribution: chx commentedComment #6
chx CreditAttribution: chx commentedComment #7
dawehnerThis looks really promising.
These constants are great!
It would be cool to document the different meaning of these different constants.
Some docs here and there would be cool
Comment #8
chx CreditAttribution: chx commentedDocumented.
Comment #10
chx CreditAttribution: chx commentedWell, that's hopeful -- now only the tests themselves are broken.
Comment #11
dawehnerLet's hope it will just pass.
Comment #13
chx CreditAttribution: chx commentedComment #14
alexpottPatch no longer applies.
Comment #15
chx CreditAttribution: chx commentedComment #17
dawehner#15: 2098111_15.patch queued for re-testing.
Comment #19
chx CreditAttribution: chx commentedComment #21
chx CreditAttribution: chx commentedArgh, blargh, what happened to the installer again?
Comment #22
chx CreditAttribution: chx commentedAccidentally, KeyValueFactory became a rather generic factory that we might want to (in a followup) move up to Component... there's nothing in there that is keyvalue bound. We could, for example, change cache settings to use the same factory and structure instead of just a single cache array. We could unify queue too just needs to split off the reliable queue factory into a separate class.
Comment #23
chx CreditAttribution: chx commentedThis was RTBC before it broke.
Comment #24
alexpottCommitted 227f21b and pushed to 8.x. Thanks!
#2100579: Add documentation to default.settings.php for override key value storage is a follow up
Comment #25
chx CreditAttribution: chx commentedWe agreed the followup will be enough documentation.
Comment #26
tstoecklerI personally think it is rather pointless, to inject 'settings' when we already inject the service_container anyway, out of which we could pull the settings. Is there any specific reason to do that?
Comment #27
alexpottArrggh.. borked commit message.
Re-committed 714f9e3 and pushed to 8.x. This time with the correct commit message - sorry chx.
Comment #28
chx CreditAttribution: chx commentedI found it cleaner. I might be wrong.
Comment #29
tstoecklerOK, that's fine by me. Just wanted to know if there's some general standard that I missed. Thanks for the answer!