Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This little patch creates 2 actions. These are basically a copy of the submit function in the comment moderation form in an actions format. This is very useful for Views Bulk Operations compatibility and in use in a comment moderation view.
- mollom_unpublish_comment
- mollom_delete_comment
Cheers,
Neil
Comment | File | Size | Author |
---|---|---|---|
#47 | mollom.actions.d6.47.patch | 13.59 KB | eshta |
#42 | mollom.actions.42.patch | 13.14 KB | eshta |
#40 | mollom.actions.40.patch | 32.93 KB | eshta |
#38 | mollom.actions.38.patch | 8.08 KB | eshta |
#33 | mollom.actions.33.patch | 7.67 KB | eshta |
Comments
Comment #1
Dave ReidAlso see #152603: Revise comment admin interface like content admin, add hook_comment_operations() since the Mollom module technically already provides these actions, but has to hack them into the current comment listing interface.
Comment #2
sunTaking into account #717212: Remove "report to Mollom" links and integrate with entity delete confirmation forms instead, we should only provide actions to report a post.
Although I'm not sure how useful such an action is.
Comment #3
sunThanks for taking the time to report this issue.
However, marking as duplicate of #245689: Integrate actions with reporting functionality on delete confirmation forms.
You can follow up on that issue to track its status instead. If any information from this issue is missing in the other issue, please make sure you provide it over there.
Comment #4
moshe weitzman CreditAttribution: moshe weitzman commentedI don't agree with marking this as a dupe. This is a small, useful feature that can be used in Views Bulk Operations and elsewhere. Making it dependant on a confirm form issue is needlessly blocking it. It has already blocked for months. If the admins disagree, feel free to set this back to dupe.
Instead of a drupal_set_message(), a watchdog() would be more consistent with core. See the action below from core. The drupal_set_message calls would look upgly after deleting a hundred spams using views bulk operations.
I'll make the above change if the committers think this patch can proceed.
Comment #5
gregglessubscribing.
I agree this is a great idea to add. I agree holding it back based on a relatively unrelated issue is unfortunate.
Ultimately this means that mollom.com will get less information about spam comments. I'm building a view to delete a few hundred spam comments on g.d.o and now instead of reporting them to mollom I will simply delete them. That is valuable information that mollom.com loses out on.
Comment #6
Mark Nielsen CreditAttribution: Mark Nielsen commentedIs there anything that can be done to hurry this along to a conclusion? I could test the patch if that helps (although - 2009? - is this going to work with the current dev release?).
I'm not sure how much longer I can use Mollom if I can't integrate it into Views Bulk Actions and Rules. Viewing individual comments and reporting them is just too time-consuming, so, like greggles, I often find my only option is to delete them and deny mollom.com the spam information.
Comment #7
anavarreSubscribe
Comment #8
gordon CreditAttribution: gordon commentedsubscribe
Comment #9
1kenthomas CreditAttribution: 1kenthomas commentedI'm going to bump the priority here. Otherwise, what can I do to help :) ?
Comment #10
deverman CreditAttribution: deverman commentedI was so surprised to find that mollom doesn't support a link in views to mark as spam or a views bulk operation!
Comment #11
ezra-g CreditAttribution: ezra-g commentedI marked #1441924: Provide hook to Views Bulk Operations as a duplicate.
Comment #12
gordon CreditAttribution: gordon commentedUpdated patch for the latest version of Mollom
Comment #13
gordon CreditAttribution: gordon commentedComment #15
gordon CreditAttribution: gordon commentedFix up issue in mollom_action_info().
Comment #16
gordon CreditAttribution: gordon commentedHere is a view which I use with great success to remove spam quickly from a site.
Comment #17
gordon CreditAttribution: gordon commentedFound a small bug when going to 2.x
Comment #18
gordon CreditAttribution: gordon commentedFix up version
Comment #19
AlfTheCat CreditAttribution: AlfTheCat commentedComment #20
gregglesI did a quick query to find the most followed, open issues for mollom module:
So, the first two are basically just people who need support and are confused by the module. The next 3 are tied for most important meaning that this issue is tied for the most followed open issue in the mollom queue.
Further - #655846: Mollom Actions and #921772: Report to Mollom 'registered spam users accounts' and delete account are pretty similar since 921772 is just chaining together two actions (if the code were organized as actions). So, 2 out of the top 4 issues are pretty related.
It's interesting to note that this issue has 12 commenters but 17 followers.
Comment #21
rooby CreditAttribution: rooby commentedHere is a bit of patch review - Damn, just realised the patch was for drupal 6, which explains the bugs I had.
So just nit-picky stuff here now.
Comments should have full stops.
I assume Preform should be Perform, and it needs a full stop.
These comments should probably have full stops instead of colons.
Should not remove the newline at the end of the file.
Plus we now need a D7 version.
Comment #22
ttkaminski CreditAttribution: ttkaminski commentedUpdated the patch to work with D7. Made some changes:
1. Enabled aggregate mode on the actions. This takes advantage of the
*_multiple()
functions, thus making the operation more optimal.2. Removed the
drupal_set_message()
. Not needed as VBO already provides information about the results of the operation.Comment #23
gordon CreditAttribution: gordon commentedBump!
In light of the recent Spamming of Groups, and they Groups users VBO and actions to allow deleting of a users content. Right NOW it is only deleting the content and not notifying mollom that this is being deleted because of SPAM. This is not helping Mollom get rid of our spam. Adding this will help Mollom combat out current spam issue.
Comment #24
Mark Nielsen CreditAttribution: Mark Nielsen commentedFeature requests shouldn't be marked Critical, according to the policy on Priority levels of issues. So I hope it's OK for me to drop it back to Major.
I doubt that upping the Priority would speed anything up anyway. Though I wish there was something that would speed progress up as it's nearly four years since indytechcook opened the issue by posting a patch :(
Comment #25
HyperGlide CreditAttribution: HyperGlide commented++ for this feature.
Comment #26
gregglesI believe this is severely hampering the performance of mollom on groups.drupal.org.
Not only is this the most followed issue in the Mollom queue, it's probably also the most duplicated. Here are other issues that are ultimately duplicate issues of this one:
#1441924: Provide hook to Views Bulk Operations
#342138: Add a 'report to Mollom' action
#338510: Implement hook_node_operations() and add actions
#921772: Report to Mollom 'registered spam users accounts' and delete account
It's confusing to me that a patch is available that adds this feature and was not reviewed by a maintainer.
I'm very happy to see the recent improvements to the mollom module/service. #273964: Accessibility problems with audio CAPTCHA was a huge item to fix. This is the next big one.
Whether it's "critical" or not from a d.o issue perspective I've believe (based on the data above) that it is critical from the perspective of value to mollom users.
Comment #27
eshta CreditAttribution: eshta commentedHi there, greggles.
A lot of this history predates me so thank you for commenting on this and bringing it up on my radar. I'm going to take a look at the latest patch (will need a re-roll, etc.) and do some testing. It may take me a few days but we'll get this rolling again ;-)
Comment #28
gregglesWonderful news. Thanks, @eshta.
Comment #29
HyperGlide CreditAttribution: HyperGlide commentedThanks @eshta++ and @greggles++
Comment #30
eshta CreditAttribution: eshta commentedRe-rolling patch.
Comment #31
eshta CreditAttribution: eshta commentedFixed some whitespace issues and added source for feedback reporting.
Questions:
Should we really be deleting the mollom data for an unpublish action?
I was looking at the current state of the hook_mollom_form_list for comments and it seems like we might leverage this instead of simply calling things directly.
The specifics that came to mind were:
Comment #32
eshta CreditAttribution: eshta commentedThis also could use a test....
Comment #33
eshta CreditAttribution: eshta commentedUpdated the patch to read delete and access callbacks from the comment form definitions so that all callbacks are called in these actions.
The last piece here is testing the actions.
FOR WATCHERS: If anyone is in need of this functionality, please test this patch :-)
Comment #34
gregglesIt looks like this is just providing actions for comments, but not for nodes nor user accounts. On g.d.o right now the most common type of spam is nodes. Are you planning to add nodes?
Comment #35
eshta CreditAttribution: eshta commentedWe could certainly extend this to nodes pretty easily I would think using a similar approach. Probably can't get to it today but will be able to in the next day or two at most (unless you want to refactor it in before then, of course).
@greggles: Would you be able to help with testing (and perhaps a test class)?
Comment #36
gregglesI'm mostly an end user of mollom in my role as spam moderator on g.d.o, so unlikely to help beyond visual patch reviews/feedback.
Comment #37
eshta CreditAttribution: eshta commentedAdding nodes is a bit more of an effort. The comment integration in place already provides delete callback handlers. Node deletion is limited to integrating with the node delete form. I'm a bit wary of just adding it in here, even with callbacks in place without lots of security checks....
I think what would be best is only having unpublish actions for nodes and comments. That is more within Mollom's area of responsibility.
Would that meet the needs?
Comment #38
eshta CreditAttribution: eshta commentedTo that end - I've attached a stab at simple unpublish actions for both comments and nodes.
Comment #39
eshta CreditAttribution: eshta commentedFunction comments are wrong here.
This should be called mollom_action_unpublish_node (and needs updated comments).
Comment #40
eshta CreditAttribution: eshta commentedFixed based on info above.
Comment #42
eshta CreditAttribution: eshta commentedUpdated for a few bug fixes and a re-roll. Also added a test of the core actions functions.
Comment #43
reujwils CreditAttribution: reujwils commentedSubscribe
Comment #44
eshta CreditAttribution: eshta commentedSo this is RTBC practically and I'm planning on rolling out a new release over the weekend that will probably include it. Any feedback from folks who think this will or won't meet their needs, please let me know so that it can be taken into account (or better yet - add on to the patch).
Comment #46
eshta CreditAttribution: eshta commentedComment #47
eshta CreditAttribution: eshta commentedComment #49
eshta CreditAttribution: eshta commented47: mollom.actions.d6.47.patch queued for re-testing.
Comment #50
eshta CreditAttribution: eshta commentedFixed version for backport test.
Comment #52
eshta CreditAttribution: eshta commented47: mollom.actions.d6.47.patch queued for re-testing.
Comment #53
eshta CreditAttribution: eshta commentedComment #56
gregglesThanks, eshta for the work on both 7.x and 6.x branches!