Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up from #1971384: [META] Convert page callbacks to controllers.
Comment | File | Size | Author |
---|---|---|---|
#13 | interdiff.txt | 2.93 KB | tim.plunkett |
#13 | routes-2102653-13.patch | 78.12 KB | tim.plunkett |
#11 | interdiff.txt | 21.83 KB | tim.plunkett |
#11 | routes-2102653-11.patch | 75.19 KB | tim.plunkett |
#9 | drupal8.system-module.2102653-9.patch | 56.99 KB | disasm |
Comments
Comment #1
tim.plunkett#2091691: Convert test non-form page callbacks to routes and controllers has an insane amount of fixes, and also touches a lot of the same code. Might be worth starting from there or waiting a day or two
Comment #2
disasm CreditAttribution: disasm commentedfirst pass converting just form_test module (which has the bulk of the callbacks). Want to see if this is green before adding the others.
Comment #4
tim.plunkettRerolled after #2091691: Convert test non-form page callbacks to routes and controllers
Comment #6
tim.plunkettWe don't want or need FileInclusionTest anymore, its obsolete (the only way to fix the tests would be to manually module_load_include(), which defeats the purpose).
The rest of the changes were mostly fixes to called form IDs or bad route paths.
Comment #8
tim.plunkettOkay this should be green, carry on with the rest of the conversions.
Comment #9
disasm CreditAttribution: disasm commentedlanguage_elements_test module converted. Unassigning since timplunkett said he might have some time to work on this.
Comment #11
tim.plunkettHere's the rest. We'll see if it passes...
Comment #13
tim.plunkettJust another case of a test directly accessing a MENU_DEFAULT_LOCAL_TASK
Comment #14
dawehnerWait, this isn't a menu callback so why is this removed entirely?
I try to figure out why this change of the path was needed, as this adds additional hunks.
I like this tiny change!
Comment #15
tim.plunkett1) It's a test, and the menu link is never used. I think when it was written it should have been type => MENU_CALLBACK, the test author just skipped it
2) batch-test/simple is the MENU_DEFAULT_LOCAL_TASK. It's like how node/{node}/view is no longer valid, or admin/structure/types/manage/{node_type}/edit.
3) Yes! Tiny wins.
Comment #16
dawehnerThank you for the explanation!
Comment #17
webchickI only saw two things that stuck out to me in my review:
Where did this test go?
Basically, we don't need it anymore because we no longer support loading forms from separate .inc files in favour of class loading.
I actually find this pretty bizarre, but it does indeed clean up the code below. Since it's a deprecated function anyway, not really worth bothering about atm.
Committed and pushed to 8.x. Thanks!