Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem
Looking at the CSS in #2059719: Content translation admin CSS file not renamed from translation_entity.admin.css I realized there is no RTL support included for paddings. That sounds like a mistake.
Proposal
Add RTL styles.
Comment | File | Size | Author |
---|---|---|---|
#6 | drupal-content-translation-admin-page-rtl-fix-2059719-6.patch | 1.28 KB | thamas |
#3 | content-lang-settings-rtl.png | 45.79 KB | thamas |
#3 | content-lang-settings-rtl-fixed.png | 40.21 KB | thamas |
#3 | drupal-content-translation-admin-page-rtl-fix-2059719-3.patch | 1.91 KB | thamas |
Comments
Comment #1
Gábor HojtsyComment #2
thamasWokin' on it :)
Comment #3
thamasHere is the patch which adds the missing padding and removes some unneeded lines. It (hopefully) also fixes some inconsistencines in drupal.base.css I found during working on the original issue.
Before:
After:
(Sorry for sending it so much later I assigned it to myself but DrupalCon catched me… ;))
Comment #4
rteijeiro CreditAttribution: rteijeiro commentedThis file doesn't exists, so patch doesn't apply :(
Comment #5
thamasOhh, it was removed two days later: https://drupal.org/node/1839318#comment-7912709
I'll reroll the patch… Thanks for the review!
Comment #6
thamasRerrolled without the removed drupal.base.css
Comment #7
thamasComment #8
rteijeiro CreditAttribution: rteijeiro commentedPatch applies well and code seems right. Well done!
Comment #9
thamasThanks for the review! :)
Comment #10
tstoecklerSorry if this is obvious, but:
Any reason to add this additional padding? I don't see the equivalent being added in ltr-mode.
Comment #11
Gábor HojtsyI think that would be the standard table cell padding that is overridden in the LTR version, so needs to set back again? @thamas, can you confirm?
Comment #12
thamasWe are overriding the 3em and 5em left padding which are defined earlier in LTR settings.
Comment #13
Gábor HojtsyTag on sprint for easier tracking.
Comment #14
plachComment #15
catchCommitted/pushed to 8.x, thanks!
Comment #16
Gábor HojtsyYay! Thanks!
Maybe you noticed the random distracting labels right near the checkboxes on the screenshots in #3, those are *not supposed to be there*. Simple RTBC issue at #2112303: Random extra text around translatability configuration is confusing.