Updated: Comment #1

Problem/Motivation

#2076085: Resolve the need for a 'title callback' using the route removed the title from the aggregator configuration menu item, which made it so that the title does not display on the Configuration page.

Steps to reproduce

  1. Clean install of Drupal 8
  2. Enable Aggregator module
  3. Navigate to admin/config

What admin/config currently looks like:
aggregator-missing-title-after.png

What we (mostly, ignore the different icons) want it to look like:
aggregator-missing-title-before.png

Proposed resolution

Re-add 'title' to admin/config/services/aggregator in aggregator_menu().

Remaining tasks

Needs a patch created

User interface changes

Title will be correctly displayed in admin/config and in page titles.

API changes

n/a

#2076085: Resolve the need for a 'title callback' using the route

CommentFileSizeAuthor
#3 admin-config-aggregator.png27.44 KB-enzo-
#2 drupal8.aggregator-module.2103285-2.patch611 bytesxeniak
#1 aggregator-missing-title-after.png27.7 KBstar-szr
#1 aggregator-missing-title-before.png28.88 KBstar-szr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
FileSize
aggregator-missing-title-before.png28.88 KB
aggregator-missing-title-after.png27.7 KB

Screenshots.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Issue summary: View changes

Add steps to reproduce and screenshots, improve problem/motivation and proposed resolution

xeniak’s picture

xeniak CreditAttribution: xeniak commented
Status: Active » Needs review
FileSize
drupal8.aggregator-module.2103285-2.patch611 bytes

Title added.

-enzo-’s picture

-enzo- CreditAttribution: -enzo- commented
Status: Needs review » Reviewed & tested by the community
FileSize
admin-config-aggregator.png27.44 KB

After apply the patch and clean cache the admin page now looks correct.

admin-config-aggregator.png

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

Can't we add the title to the actual route instead? We're trying to kill off hook_menu.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

This is all menu link based. It needs to be in there until #2047633: Move definition of menu links to hook_menu_link_defaults(), decouple key name from path, and make 'parent' explicit happens.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

Ah, that makes sense. Thanks!

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Issue summary: View changes

Add note about different icons in the screenshots

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 0f4bacc and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Fix screenshot URL