Updated: Comment #1
Problem/Motivation
#2076085: Resolve the need for a 'title callback' using the route removed the title from the aggregator configuration menu item, which made it so that the title does not display on the Configuration page.
Steps to reproduce
- Clean install of Drupal 8
- Enable Aggregator module
- Navigate to admin/config
What admin/config currently looks like:
What we (mostly, ignore the different icons) want it to look like:
Proposed resolution
Re-add 'title' to admin/config/services/aggregator in aggregator_menu().
Remaining tasks
Needs a patch created
User interface changes
Title will be correctly displayed in admin/config and in page titles.
API changes
n/a
Related Issues
#2076085: Resolve the need for a 'title callback' using the route
Comment | File | Size | Author |
---|---|---|---|
#3 | admin-config-aggregator.png | 27.44 KB | -enzo- |
#2 | drupal8.aggregator-module.2103285-2.patch | 611 bytes | xeniak |
#1 | aggregator-missing-title-after.png | 27.7 KB | star-szr |
#1 | aggregator-missing-title-before.png | 28.88 KB | star-szr |
Comments
Comment #1
star-szrScreenshots.
Comment #1.0
star-szrAdd steps to reproduce and screenshots, improve problem/motivation and proposed resolution
Comment #2
xeniak CreditAttribution: xeniak commentedTitle added.
Comment #3
-enzo- CreditAttribution: -enzo- commentedAfter apply the patch and clean cache the admin page now looks correct.
Comment #4
damiankloip CreditAttribution: damiankloip commentedCan't we add the title to the actual route instead? We're trying to kill off hook_menu.
Comment #5
tim.plunkettThis is all menu link based. It needs to be in there until #2047633: Move definition of menu links to hook_menu_link_defaults(), decouple key name from path, and make 'parent' explicit happens.
Comment #6
damiankloip CreditAttribution: damiankloip commentedAh, that makes sense. Thanks!
Comment #6.0
damiankloip CreditAttribution: damiankloip commentedAdd note about different icons in the screenshots
Comment #7
alexpottCommitted 0f4bacc and pushed to 8.x. Thanks!
Comment #8.0
(not verified) CreditAttribution: commentedFix screenshot URL