Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jlindsey15’s picture

Assigned: jlindsey15 » Unassigned
Status: Active » Needs review
FileSize
1.78 KB

Status: Needs review » Needs work

The last submitted patch, rename-global-user-2062791-1.patch, failed testing.

sergeypavlenko’s picture

Status: Needs work » Needs review
FileSize
1.89 KB

Please make sure you have the correct comment?

Status: Needs review » Needs work

The last submitted patch, drupal8.node-module.2062791-3.patch, failed testing.

sergeypavlenko’s picture

Status: Needs review » Needs work

The last submitted patch, drupal8.node-module.2062791-5.patch, failed testing.

m1r1k’s picture

Issue tags: +blocked-by-request-scope

For easy tracking

joelpittet’s picture

Status: Needs work » Needs review
Issue tags: -blocked-by-request-scope

#5: drupal8.node-module.2062791-5.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +blocked-by-request-scope

The last submitted patch, drupal8.node-module.2062791-5.patch, failed testing.

m1r1k’s picture

Status: Needs work » Needs review
FileSize
1.9 KB

Updated patch:

Status: Needs review » Needs work

The last submitted patch, node-module-remove-global-user-2062791-10.patch, failed testing.

joelpittet’s picture

Status: Needs work » Needs review
FileSize
8.57 KB
6.97 KB

There seemed to be a few more missing. I hope this is right. Interdiff from #10

Status: Needs review » Needs work

The last submitted patch, 2062791-12-global-user-node.patch, failed testing.

joelpittet’s picture

Status: Needs work » Needs review
FileSize
8.09 KB

Re-rolled, manually.

The last submitted patch, 2062791-14-global-user-node.patch, failed testing.

joelpittet’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 14: 2062791-14-global-user-node.patch, failed testing.

joelpittet’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 14: 2062791-14-global-user-node.patch, failed testing.

joelpittet’s picture

Issue summary: View changes
Status: Needs work » Needs review
Parent issue: » #2047951: [META] Remove calls to deprecated global $user and $GLOBALS['user']
FileSize
7.69 KB

Re-rolled.

Status: Needs review » Needs work

The last submitted patch, 20: 2062791-20-global-user-node.patch, failed testing.

natemow’s picture

Status: Needs work » Needs review
FileSize
6.64 KB

Re-rolled.

natemow’s picture

Re-rolled.

joelpittet’s picture

Status: Needs review » Reviewed & tested by the community

Nice work @natemow #23 is ready to ship.

Double checked to see if there were any global $user or $GLOBALS['user'] in the node module and it's clean.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.