Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
When trying to edit an effect with an invalid (inexistent or deleted) effect ID in URL, Drupal returns 500. It should return 401.
Comment | File | Size | Author |
---|---|---|---|
#17 | no-effect-2063403-17.patch | 7.21 KB | claudiu.cristea |
#15 | no-effect-2063403-15.patch | 5.97 KB | claudiu.cristea |
#15 | interdiff.txt | 810 bytes | claudiu.cristea |
#11 | no-effect-2063403-11.patch | 7.32 KB | claudiu.cristea |
#11 | interdiff.txt | 2.5 KB | claudiu.cristea |
Comments
Comment #1
claudiu.cristeaHere's a patch showing this bug.
Comment #3
claudiu.cristeaHere's the fix.
Comment #4
claudiu.cristeaComment #5
tim.plunkettThis should not catch the exception, its up to an individual plugin bag.
This looks wrong
nonexistent
Comment #7
andypostShould be part of #1881630: [meta] Determine how to respond to invalid plugins (plugin dependencies)
Also better to finish upgrade path first #2049465: Upgrade of image styles and effects broken
Comment #8
claudiu.cristeaJust finished patch when you posted :)
Comment #9
claudiu.cristeaThis needs reviews or RTBC
Comment #10
dawehnerShould be @file\nContains ...
It is a bit odd that the message is not the first parameter of the exception.
It would be great to display that the image effect could not be created/does not exist.
Comment #11
claudiu.cristea@dawehner,
I know but I need a way to pass the plugin id without a message by default. It's not against any rule.
Fixed others, see interdiff.
Comment #12
claudiu.cristeaYay, passed.
Comment #13
jibranAs #10 is addressed and #1 contains test only patch. So I think it is ready for RTBC.
Comment #14
alexpottNeeds work since #1969572: Make Uuid a service has landed
Comment #15
claudiu.cristeaHere with uuid as service.
Comment #17
claudiu.cristeaOh, missed
Drupal\Component\Plugin\Exception\PluginException
.Comment #18
jibranThanks @claudiu.cristea for fixing this. Green with Uuid service so back to RTBC.
Comment #19
Xano#17: no-effect-2063403-17.patch queued for re-testing.
Comment #20
alexpottCommitted a6d19bf and pushed to 8.x. Thanks!
Removed unnecessary use statements during commit.