Remove the @Annotation class and @Translation class use statement.

This is postponed on #2090353: Don't require to put the use statement into plugin classes

CommentFileSizeAuthor
#14 2094003-14.patch53.47 KBswentel
#14 interdiff.txt5.24 KBswentel
#10 2094003-10.patch48.22 KBswentel
#3 2094003-3.patch25.17 KBswentel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

swentel’s picture

swentel CreditAttribution: swentel commented
Assigned: Unassigned » swentel
Issue tags: +Field API

Working on this already on top of the other patch.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Postponed » Active

Working on it

swentel’s picture

swentel CreditAttribution: swentel commented
FileSize
2094003-3.patch25.17 KB

Let's see.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Active » Needs review
yched’s picture

yched CreditAttribution: yched commented

Wasn't aware we could drop those already. Way cool.

While ee're in there, the plugin managers have a lot of unneeded "use" cruft too. Maybe ee could clean those as well ?

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented

Let's create Meta for

unneeded "use"

because these days we are creating a lot of metas

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

This will probably conflict a lot with https://drupal.org/node/2051923, because that's renaming a class in the use statements and is critical and almost ready, postpone?

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs review » Postponed

This can wait.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Postponed » Active

this can go on again

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Active » Needs review
FileSize
2094003-10.patch48.22 KB

Should have them all

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs review » Reviewed & tested by the community

Green and Clean so RTBC.

swentel’s picture

swentel CreditAttribution: swentel commented

#10: 2094003-10.patch queued for re-testing.

swentel’s picture

swentel CreditAttribution: swentel commented

Double check after #1953408: Remove ArrayAccess BC layer from field config entities went in.

swentel’s picture

swentel CreditAttribution: swentel commented
FileSize
interdiff.txt5.24 KB
2094003-14.patch53.47 KB

Cleaned up some more in plugin managers and other files, really good to go now.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.