Replace user_access() calls with $account->hasPermission() in menu module [#2062005]

Let's start to convert all calls to user_access() with the new AccountInterface::hasPermission() method.

Part of #2048171: [meta] Replace user_access() calls with $account->hasPermission() wherever possible.

Change records for this issue:

user_access() got converted to a method on the user/accountInterface

Comment	File	Size	Author
#3	drupal-menu_replace_user_access_2062005-3.patch	569 bytes	InternetDevels
#3
#1	drupal-menu_replace_user_access_2062005.patch	2.73 KB	InternetDevels
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

InternetDevels CreditAttribution: InternetDevels commented 10 August 2013 at 16:01

Status:

Active

» Needs review

File	Size
drupal-menu_replace_user_access_2062005.patch	2.73 KB

In some cases $request does not contain information about account. I've used $request instead, but looks like this issue requires more deep investigation.

Comment #2

andypost

he/him

Russian

CreditAttribution: andypost commented 29 August 2013 at 17:04

Component:	user system	» menu.module
Status:	Needs review	» Needs work

+++ b/core/modules/menu/lib/Drupal/menu/Access/DeleteLinkAccessCheck.php
@@ -27,7 +27,8 @@ public function appliesTo() {
+    $account = \Drupal::request()->attributes->get('_account');

Depends on #2048223: Add $account argument to AccessCheckInterface::access() method and use the current_user service

+++ b/core/modules/menu/menu.module
@@ -529,6 +529,7 @@ function menu_form_node_form_alter(&$form, $form_state) {
+  $account = Drupal::request()->attributes->get('_account');

Use Drupal::currentUser() service https://drupal.org/node/2032447