Remove drupal_set_title in menu module controllers [#2102461]

Subtask of #1830588: [META] remove drupal_set_title() and drupal_get_title()

Problem/Motivation

Using procedural drupal_set_title() inside controller class is not encouraged.

Proposed resolution

Replace drupal_set_title() with #title in page return array.

Remaining tasks

Issue patch

User interface changes

Refer parent issue at #1830588: [META] remove drupal_set_title() and drupal_get_title()

API changes

Refer parent issue at #1830588: [META] remove drupal_set_title() and drupal_get_title()

Comment	File	Size	Author
#5	2102461-drupal-remove_drupal_set_title_in_menu_module-5.patch	1.75 KB	vijaycs85
#5
#5	2102461-diff-3-5.txt	639 bytes	vijaycs85
#3	drupal-remove_drupal_set_title_in_menu_module-2102461-3.patch.patch	1.75 KB	InternetDevels
#3
#1	remove_drupal_set_title_in_menu_module-2102461-1.patch	1.77 KB	InternetDevels
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

InternetDevels CreditAttribution: InternetDevels commented 5 October 2013 at 11:02

Status:

Active

» Needs review

File	Size
remove_drupal_set_title_in_menu_module-2102461-1.patch	1.77 KB

Comment #2

5 October 2013 at 11:08

Status:

Needs review

» Needs work

The last submitted patch, remove_drupal_set_title_in_menu_module-2102461-1.patch, failed testing.

Comment #3

InternetDevels CreditAttribution: InternetDevels commented 5 October 2013 at 11:37

Status:

Needs work

» Needs review

File	Size
drupal-remove_drupal_set_title_in_menu_module-2102461-3.patch.patch	1.75 KB

Comment #4

dawehner

German

CreditAttribution: dawehner commented 6 October 2013 at 00:33

+++ b/core/modules/menu/lib/Drupal/menu/MenuFormController.php
@@ -70,7 +70,7 @@ public function form(array $form, array &$form_state) {
-      drupal_set_title(t('Edit menu %label', array('%label' => $menu->label())), PASS_THROUGH);
+      $form['#title'] = t('Edit menu %label', array('%label' => $menu->label()));

We could use $this->t() instead of t() directly here.