This was split from #2048827: Move Image toolkit API from system.module to Drupal\Core.

CommentFileSizeAuthor
#4 inject-config-factory-2105621-4.patch5.36 KBclaudiu.cristea
#4 interdiff.txt510 bytesclaudiu.cristea
#3 inject-config-factory-2105621-3.patch5.17 KBclaudiu.cristea
#3 interdiff.txt1.84 KBclaudiu.cristea
#1 inject-config-factory-2105621-1.patch3.2 KBclaudiu.cristea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea commented
Status: Active » Needs review
FileSize
inject-config-factory-2105621-1.patch3.2 KB

Here's a patch.

Status: Needs review » Needs work

The last submitted patch, inject-config-factory-2105621-1.patch, failed testing.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea commented
Status: Needs work » Needs review
FileSize
interdiff.txt1.84 KB
inject-config-factory-2105621-3.patch5.17 KB

Forgot to change in tests.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea commented
FileSize
interdiff.txt510 bytes
inject-config-factory-2105621-4.patch5.36 KB

Cleaned also an unused use statement.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea commented

Created a meta-issue for all image work here #2105863: [meta] Images, toolkits and operations.

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
CreditAttribution: mr.baileys commented
Status: Needs review » Reviewed & tested by the community

Looks good!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented

Committed and pushed to 8.x. Thanks!

Off-topic: Want to put yourself down for image module in MAINTAINERS.txt? :) seems like you're doing a bunch of work on it.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea commented

Re on #7: OK :)

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea commented
Assigned: claudiu.cristea » Unassigned

Can we set this to 'fixed' now?

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
CreditAttribution: mr.baileys commented
Status: Reviewed & tested by the community » Fixed

Yup, commit: http://drupalcode.org/project/drupal.git/commit/6207fe9 and no additional work to be done...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.