API page: https://api.drupal.org/api/drupal/core%21modules%21block%21lib%21Drupal%...

Enter a descriptive title (above) relating to class RouteSubscriber, then describe the problem you have found:

The class documentation for this class just says "Listens to the dynamic route events.". This doesn't really tell me what the class does. It would be better if it (with the corrected verb tense!) used the documentation from its method, which at least tells me it is providing dynamic routes for the block module, which is what the class actually does.

CommentFileSizeAuthor
#3 blockRouteSubscriber-2105807-3.patch850 bytesStephaneQ
#1 reroll-test.patch2.78 KBAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

FileSize
2.78 KB

I'm attempting to re-roll the latest patch against the latest D8.

jhodgdon’s picture

I think the patch in #1 is for a different issue?

StephaneQ’s picture

Status: Active » Needs review
FileSize
850 bytes

Here is another patch.

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Thanks! Looks good to me.

Anonymous’s picture

I'm sorry about that...a stupid mistake on my part...trying to learn core contribution

jhodgdon’s picture

Status: Reviewed & tested by the community » Fixed

Thanks again! Committed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.