Follow-up from #1653026: [META] Use properly typed values in module configuration.
Problem/Motivation
All integers, Booleans, and even octal numbers in config object files are converted to strings.
Proposed resolution
#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.
Remaining tasks
system.authorize.yml
system.cron.yml
system.date.yml
system.date_format.fallback.yml
system.date_format.html_date.yml
system.date_format.html_datetime.yml
system.date_format.html_month.yml
system.date_format.html_time.yml
system.date_format.html_week.yml
system.date_format.html_year.yml
system.date_format.html_yearless_date.yml
system.date_format.long.yml
system.date_format.medium.yml
system.date_format.short.yml
system.file.yml
system.image.gd.yml
system.maintenance.yml
system.menu.account.yml
system.menu.admin.yml
system.menu.footer.yml
system.menu.main.yml
system.menu.tools.yml
system.module.yml
system.performance.yml
system.rss.yml
system.site.yml
system.theme.global.yml
system.theme.yml
entity_test/config/entity.view_mode.entity_test_render.full.yml
entity_test/config/entity.view_mode.entity_test_render.test.yml
entity_test/entity_test.routing.yml
update_script_test/config/update_script_test.settings.yml
User interface changes
NO
API changes
NO
Related Issues
Parent: #1653026: [META] Use properly typed values in module configuration
Comment | File | Size | Author |
---|---|---|---|
#13 | 2105993-system-config-cleanup-13.patch | 12.9 KB | vijaycs85 |
#12 | grepdlist.txt | 1006 bytes | YesCT |
#10 | 2105993-system-yml-type-casting-10.patch | 13.39 KB | vijaycs85 |
#10 | 2105993-diff-8-10.txt | 8.37 KB | vijaycs85 |
#8 | 2105993-system-yml-type-casting-8.patch | 5.02 KB | vijaycs85 |
Comments
Comment #0.0
vijaycs85updating files list.
Comment #1
vijaycs85Initial patch...
Comment #3
vijaycs85removing route 'TRUE' => TRUE changes..
Comment #5
vijaycs85Removing routing changes, as advised by @timplunkett on IRC:
Comment #6
vijaycs85Comment #6.0
vijaycs85Updated issue summary with test modules
Comment #8
vijaycs85Re-roll...
Comment #10
vijaycs85This change worth for a separate issue. Fixed all places where we did type casting (octdec() to convert string to oct) for file permission. Just love it testbot :)
Comment #11
YesCT CreditAttribution: YesCT commentedI'm reviewing this.
Comment #12
YesCT CreditAttribution: YesCT commentedThe issue summary lists more files than the patch changed.
for patch in #10
git diff --name-only
gives:
For example, listed in the issue summary, but not changed in the patch is
system.rss.yml
----
Also, how was the list in the remaining tasks arrived at?
find core/modules/system -type f -name "*.yml" | wc -l
yields 133
an example: core/modules/system/tests/modules/twig_extension_test/twig_extension_test.services.yml
oh, services.. and routes and local tasks are not config (or at least not config we are looking at here)
find core/modules/system -type f -name "*.yml" | grep -v local_tasks.yml | grep -v services.yml | grep -v routing.yml | grep -v local_actions.yml | wc -l
reduces to 99
find core/modules/system -type f -name "*.yml" | grep -v local_tasks.yml | grep -v services.yml | grep -v routing.yml | grep -v info.yml | wc -l
reduces to 40
ok. so.
I put the list from the issue summary into a file, and took off the dir names from the few at the end.
Also redirected the output of the grepped find.
find core/modules/system -type f -name "*.yml" -exec basename {} \; | grep -v local_tasks.yml | grep -v services.yml | grep -v routing.yml | grep -v info.yml | grep -v local_actions.yml > grepdlist.txt
Then diff'd those two files.
diff issuesummarylist.txt grepdlist.txt
filenames pointing to the left are in the summary,
pointing to the right are from the find
attaching also the output with the full paths.
Now, which from the find list are not touched by this patch?
cat patchchanged.txt |awk -F/ '{print $NF}' > patchchanged-nopath.txt
diff patchchanged-nopath.txt grepdlist.txt
So files pointing to the left are changes to files other than the config files found by the grep'd find,
files pointing to the right are not changed by this patch but are in the grep'd find.
========
A next step: figuring out why the grep'd find list of 40 files is different than those listed in the issue summary.
Another next step: looking at those (that were even listed in the issue summary) and seeing if they really need no change.
Comment #12.0
YesCT CreditAttribution: YesCT commentedUpdated issue summary removing *.routing.yml files.
Comment #13
vijaycs85Re-rolling...
Comment #14
vijaycs85The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) is copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.