Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Clicking on paths /admin/compact/on or /admin/compact/off gives a fatal error:
Symfony\Component\Routing\Exception\RouteNotFoundException: Route "front" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 127 of drupal-8/core/lib/Drupal/Core/Routing/RouteProvider.php).
For example: click on "Hide descriptions" or "Show descriptions" in admin/config.
Comment | File | Size | Author |
---|---|---|---|
#20 | 2076551-20-test_only.patch | 1.9 KB | pfrenssen |
#20 | 2076551-20.patch | 2.48 KB | pfrenssen |
#11 | 2076551-11-tests_only.patch | 1.9 KB | pfrenssen |
#11 | 2076551-11.patch | 2.48 KB | pfrenssen |
#11 | interdiff.txt | 2.49 KB | pfrenssen |
Comments
Comment #1
pwolanin CreditAttribution: pwolanin commentedThis fixes the bug, but we should add some minimal test coverage too.
Comment #2
pfrenssenHere's a test.
Comment #3
pfrenssenRemoving tag.
Comment #4
tstoecklerFor context, this was broken in #1987810: Convert system_admin_config_page() to a new style controller.
Comment #5
tstoecklerThis code looks strange, can you comment on why this was needed?
Comment #6
pfrenssenIf I do not put that line there the front page is not defined and the redirect is not executed.
By default the frontpage is 'node', but the node module is not enabled in this test, so I opted for 'admin'.
Comment #7
pfrenssenWoops, I copy/pasted these lines and forgot to change "on" into "off"
Shall we reword the comment for the front page configuration as well? Maybe
Comment #8
tstoecklerYes, a more elaborate comment would be great.
I still don't know really get why that is necessary.
As far as I know, the default front page is 'user' in D8 and user.module should always be enabled. But let's not hold this up on any more on that detail. As long as it's green...
Comment #9
andypostshould be
$this->container->get(...
Comment #10
pfrenssenWill address remarks.
Comment #11
pfrenssen@tstoeckler, you're right. The front page is by default indeed set to
'user'
, but if a user is logged in this redirects to'user/{uid}'
. This causes$this->assertUrl('<front>')
to fail, since it looks at the redirected url and this does not match the original url.The test now checks for the redirected url.
Comment #12
pfrenssenComment #13
dawehnerHaven't we decided to go with 'front' as routename?
Comment #14
tim.plunkettIf so, we need to change it back.
Comment #15
tstoecklerThanks @pfrenssen for figuring that out. It's much clearer now, especially with the comment!
Comment #16
pfrenssenIt's been over two weeks, let's see if this needs a reroll.
Comment #17
pfrenssen#11: 2076551-11-tests_only.patch queued for re-testing.
Comment #18
pfrenssen#11: 2076551-11.patch queued for re-testing.
Comment #20
pfrenssenRerolled against latest HEAD.
Comment #21
dawehnerThis looks good to go.
Comment #22
pwolanin CreditAttribution: pwolanin commented#20: 2076551-20.patch queued for re-testing.
Comment #24
dawehner#20: 2076551-20.patch queued for re-testing.
Comment #25
tstoecklerComment #26
webchickCommitted and pushed to 8.x. Thanks!
Comment #27.0
(not verified) CreditAttribution: commentedAdded manual testing instructions.