I wanted to propose this small patch to rename all cache prefixes in the same way. This discussion was started in the following ticketSearchPluginManager plugin definitions aren't cached and I thought it was nice to have something consistent between them.

Any suggestion is more than welcome on either include other files I missed or leave some of them I patched alone for a specific reason currently unknown to me.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

I do like the _plugins suffix as it makes it clear that this is about the plugin information.

Is there a reason why this hunk in LocalTaskManager was not changed?

    $this->setCacheBackend($cache, $language_manager, 'local_task', array('local_task' => TRUE));
</coder>

as well as this line in ConfigMapperManager:
<code>    $this->setCacheBackend($cache_backend, $language_manager, 'config_translation_info');

You could argue that the local task manager stores more than just the local task plugin information as it also stores information by route.

Bladedu’s picture

Status: Needs review » Needs work

Good remark and I agree with you that localManager should also be included. I will reroll the previous patch including the missing plugin managers.

Thanks for the review :)

Bladedu’s picture

Status: Needs work » Needs review
FileSize
599 bytes
13.1 KB

Included LocalTaskManager to the list of renamed cache prefixes.
For the config_translation module, I'll propose a patch to its project issue list.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Great, thank you!

catch’s picture

Status: Reviewed & tested by the community » Needs work

The last submitted patch, plugins_cache_prefixes_name_convention_consistency-2.patch, failed testing.

Bladedu’s picture

Status: Needs work » Needs review
FileSize
1.3 KB
13.13 KB

Re-rolled patch. ImageToolkitManager was moved from system module to ImageToolkit module.

pfrenssen’s picture

Status: Needs review » Reviewed & tested by the community

Excellent, thanks! Back to RTBC.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.