Updated: Comment #N

Problem/Motivation

+++ b/core/includes/menu.inc
@@ -1979,6 +1986,20 @@ function menu_local_tasks($level = 0) {
+      foreach ($local_tasks as $level => $items) {

This is overriding the $level variable that is being passed into the function. I'm not 100% through with debugging, but I think this might be the cause of some missing tabs in config_translation that I'm having a problem with.

Proposed resolution

fix it.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 duplicate_variables.patch721 byteststoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Active » Needs review
Issue tags: +Needs tests
FileSize
duplicate_variables.patch721 bytes

Uploading patch from the original issue here.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Issue summary: View changes

Added related issue, where this was found

jhedstrom queued 1: duplicate_variables.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: duplicate_variables.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Issue summary: View changes
Status: Needs work » Fixed

By looking at \Drupal\Core\Menu\Plugin\Block\LocalTasksBlock and \Drupal\Core\Menu\LocalTaskManager this no longer seems to be an issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.