Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Steps to reproduce:
- Install Drupal with the standard profile
- Enable the Content Translation module
- Enable comment translation for the Article bundle
- Create a new article
- Post a comment
- Access the comment translation overview through the "translate" link
Expected result: the translation overview page is shown.
Actual result: the following exception is thrown:
Symfony\Component\Routing\Exception\RouteNotFoundException: Route "comment_permalink" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 127 of /var/www/test.dd/core/lib/Drupal/Core/Routing/RouteProvider.php).
The exception is thrown while rendering comment local tasks/actions.
Related
Comment | File | Size | Author |
---|---|---|---|
#27 | content_translation-2106349-27.patch | 13.92 KB | dawehner |
#27 | interdiff.txt | 1.8 KB | dawehner |
#21 | content_translation-2106349-21.interdiff.txt | 869 bytes | plach |
#21 | content_translation-2106349-21.patch | 13.67 KB | plach |
#15 | content_translation-2106349-15.interdiff.txt | 677 bytes | plach |
Comments
Comment #0.0
plachUpdated issue summary.
Comment #0.1
plachUpdated issue summary.
Comment #1
BerdirTry comment.permalink instead of comment_permalink. Same for the others in that file.
Comment #2
plachAlready tried that and I get a new exception:
Not sure how I am supposed to proceed :(
Test coverage for this can be provided by simply reverting the change introduced in #2004626-87: Make non-configurable field translation settings available in the content language settings.
Comment #3
Gábor HojtsyAll local tasks in comment.local_tasks.yml need to use the comment DOT notation, not underscores. I noted this in an unrelated issue and the fix got removed in that patch, since it still worked kind of with comment_menu() having those tabs also. This would be the cleanup for comment stuff AFAIS.
Comment #5
Gábor HojtsyRerolled for current head, less changes needed in local_tasks.yml, since the task names now use dots. The route names don't, so the tabs basically refer to nonexistent routes.
Comment #6
plachLater I will move here the tests added in #2004626: Make non-configurable field translation settings available in the content language settings. Those should provide us the test coverage we are currently missing.
Comment #7
plachStill failing with:
It seems there's an inconsistency between the expected variable name (
comment
) and the actual variable name (entity
).Comment #8
plachComment #8.0
plachUpdated issue summary.
Comment #9
dawehnerThis is my idea to fix it.
Comment #11
plachThis is needed to fix some unintended failures in #7. It should be incorporated in the next patch.
Comment #12
webchickComment #13
dawehnerThis fixes nearly all of the tests.
Could it be that the entity_test_mul should have a label entity key in order to be translatable?
Comment #15
plachOf course :)
Comment #16
plachd.o.--
Comment #17
Berdirdebug() is still in there...
Comment #19
Berdir#15: content_translation-2106349-15.patch queued for re-testing.
Comment #21
plachRerolled and removed the debug leftover.
Comment #22
YesCT CreditAttribution: YesCT commented#2102125-19: Big Local Task Conversion related to the dot underscore naming for local tasks.
Comment #22.0
YesCT CreditAttribution: YesCT commentedUpdated issue summary.
Comment #23
dawehnerThe interdiff in #2106349-15: Comment translation overview has broken local tasks looks just perfect. I would love to RTBC that.
Comment #24
YesCT CreditAttribution: YesCT commentedI read the patch.
titles and labels are matching, uses correct naming convention, removes local tasks from hook_menu that are in comment.local_tasks.yml or already in comment.routing.yml
weight of delete is different. trying manually: both before and after, delete is first in the list of links: " delete edit reply approve"
also, I dont see /view in the patched version. I'll try it manually. Both before and after the patch comment/1/view gives page not found, so ok.
this looks ok to me. rtbc.
Comment #25
YesCT CreditAttribution: YesCT commentedreplacing tag lost in cross post.
Comment #25.0
YesCT CreditAttribution: YesCT commentedUpdated issue summary.
Comment #26
catchWhy do we get $entity_type from the request, then later get it again from $entity?
Comment #27
dawehnerThere is no reason at all.
Removed the double usage of $entity_type.
Comment #28
plachChanges look sensible to me: RTBC again if the testbot agrees.
Comment #29
catchCommitted/pushed to 8.x, thanks!
Comment #30.0
(not verified) CreditAttribution: commentedUpdated issue summary.