Background:
This issue is part of the task to update the hook_help texts of the Drupal 8 modules:
#1908570: [meta] Update or create hook_help() texts for D8 core modules

Tasks:
- review / write the hook_help text according to help guidelines

CommentFileSizeAuthor
#2 drupal8-updated-help-2091307-2.patch2.29 KBSree
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sree’s picture

Sree CreditAttribution: Sree commented

The Private downloads part seems missing ...

Sree’s picture

Sree CreditAttribution: Sree commented
Status: Active » Needs review
FileSize
drupal8-updated-help-2091307-2.patch2.29 KB

Updated help about files download method

Status: Needs review » Needs work

The last submitted patch, drupal8-updated-help-2091307-2.patch, failed testing.

Sree’s picture

Sree CreditAttribution: Sree commented
Status: Needs work » Needs review

#2: drupal8-updated-help-2091307-2.patch queued for re-testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

Thanks! The added text seems like kind of a good idea, but it is too vague to actually be useful. Also, the new sentence doesn't end in a ".". If this information is necessary, it should be here, so that it can be translated and be available within the site. We can't force people to go read a handbook page in English.

You should also refer to the System module help page for more information about file storage. In Drupal 7 and 8, you don't set up one default type of file storage anyway -- a site usually has both public and private files. So what is said here sounds wrong? Can you choose which one to put your color files in? If so, this should be mentioned.

Looking at the existing help as a whole, we also need to update the links according to
https://drupal.org/node/632280#url-note
And we don't want to call it the "online handbook" any more -- see https://drupal.org/node/632280 for proper wording.

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Issue summary: View changes
Status: Needs work » Closed (duplicate)

The hook_help text for the Color module got changed as part of a meta issue to review all help texts and is fixed in #2031639: Update hook_help for Color module.