Support from Acquia helps fund testing for Drupal Acquia logo

Comments

claudiu.cristea’s picture

Assigned: Unassigned » claudiu.cristea
Priority: Normal » Minor
Status: Active » Needs review
Issue tags: +API clean-up, +API consistency
FileSize
2.17 KB

Patch.

dawehner’s picture

Status: Needs review » Needs work

We should at least adapt the existing implementations as well. They work because we now have magic loading of annotations.

dawehner’s picture

If you apply the patch there is still some use Drupal\system\Annotation\ImageToolkit;statements in core.

claudiu.cristea’s picture

Status: Needs work » Needs review
FileSize
2.85 KB

Here with cleaning of use statements.

claudiu.cristea’s picture

Did it again :). Interdiff to #1.

claudiu.cristea’s picture

Right patch

fietserwin’s picture

Status: Needs review » Needs work

I did a global search on " extends plugin" to find all annotation classes. They are always in an Annotation subdirectory. Most of the times they are under an Annotation subdirectory of the directooy where the plugin type itself can be found. The only exception is Action which is directly under /Core/Annotation instead of /Core/Action/Annotation.

So the file should be moved to Core\ImageToolkit\Annotation. and the namespace should be adapted accordingly.

claudiu.cristea’s picture

Priority: Minor » Normal
Status: Needs work » Needs review
FileSize
1.6 KB
4.5 KB

OK. Moved under Annotation/.

Also changed priority to 'normal' as this blocks #2073759: Convert toolkit operations to plugins.

mondrake’s picture

Status: Needs review » Reviewed & tested by the community

Under Annotation/ makes it more understandable, I believe.

Grepped the codebase after applying #8:

  • no more uses of the annotation class in the toolkit plugins (3 of them, GDToolkit, TestToolkit and BrokenToolkit)
  • no more API files under the system module, just the GDToolkit plugin implementation

RTBC

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.