Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is a follow up from #2048827: Move Image toolkit API from system.module to Drupal\Core.
Moving the toolkit stuff to \Drupal\Core
, we forgot \Drupal\system\Annotation\ImageToolkit
under system module. Let's move it under \Drupal\Core\ImageToolkit
too.
Comment | File | Size | Author |
---|---|---|---|
#8 | move-toolkit-annotation-class-2108077-8.patch | 4.5 KB | claudiu.cristea |
#8 | interdiff.txt | 1.6 KB | claudiu.cristea |
#6 | move-toolkit-annotation-class-2108077-5.patch | 4.43 KB | claudiu.cristea |
#5 | move-toolkit-annotation-class-2108077-5.patch | 34 bytes | claudiu.cristea |
#5 | interdiff.txt | 2.04 KB | claudiu.cristea |
Comments
Comment #1
claudiu.cristeaPatch.
Comment #2
dawehnerWe should at least adapt the existing implementations as well. They work because we now have magic loading of annotations.
Comment #3
dawehnerIf you apply the patch there is still some
use Drupal\system\Annotation\ImageToolkit;
statements in core.Comment #4
claudiu.cristeaHere with cleaning of use statements.
Comment #5
claudiu.cristeaDid it again :). Interdiff to #1.
Comment #6
claudiu.cristeaRight patch
Comment #7
fietserwinI did a global search on " extends plugin" to find all annotation classes. They are always in an Annotation subdirectory. Most of the times they are under an Annotation subdirectory of the directooy where the plugin type itself can be found. The only exception is Action which is directly under /Core/Annotation instead of /Core/Action/Annotation.
So the file should be moved to Core\ImageToolkit\Annotation. and the namespace should be adapted accordingly.
Comment #8
claudiu.cristeaOK. Moved under Annotation/.
Also changed priority to 'normal' as this blocks #2073759: Convert toolkit operations to plugins.
Comment #9
mondrakeUnder Annotation/ makes it more understandable, I believe.
Grepped the codebase after applying #8:
use
s of the annotation class in the toolkit plugins (3 of them, GDToolkit, TestToolkit and BrokenToolkit)RTBC
Comment #10
webchickCommitted and pushed to 8.x. Thanks!