Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Ubercart Paymill Integration
Module for Ubercart integration with Paymill payment gateway.
Sandbox project: https://drupal.org/sandbox/topsitemakers/1846242
Git clone command: git clone http://git.drupal.org/sandbox/topsitemakers/1846242.git uc_paymill
Automatic code review results
Coder and [pareview.sh] checks are already performed and reported only 2 issues:
@file
block missing inuc_paymill.js
- it is there already, not sure if this is a glitch in Coder moduleUnused variable $get_active_keys
- this is left only for developer clarity and make it easier to understand what for is that parameter
Reviews of other projects
- Rasp (theme)
https://drupal.org/node/2094859#comment-7885949
https://drupal.org/node/2094859#comment-7888647 - Node Revision Bulk Delete (module)
https://drupal.org/node/2092851#comment-7888207 - TestimonialBlocks (module)
https://drupal.org/node/2087221#comment-7888375 - D7 Mobile boilerplate (theme)
https://drupal.org/node/2078603#comment-7888899
Thanks!
Comments
Comment #1
kscheirerAll user accounts are for individuals. Accounts created for more than one user or those using anonymous mail services will be blocked when discovered (see Get a Drupal.org account).
Can you confirm that the topsitemakers account is a single user? Please change your account information and enter your realname.
If you prefer, we can also promote this sandbox to a full project without granting you "git vetted user" status.
----
Top Shelf Modules - Crafted, Curated, Contributed.
Comment #2
aramboyajyan CreditAttribution: aramboyajyan commentedThis account is individual, and I'm the sole user of this account.
To avoid confusion, I updated the "sponsored by" line on project landing page and in README.txt file.
I also updated my real name here on Drupal.org.
Let me know if this is sufficient.
Thanks.
Comment #3
kscheirerYup, that's good, thanks!
Comment #4
TR CreditAttribution: TR commentedComment #5
sanchiz CreditAttribution: sanchiz commentedI can not turn the module through Drush, because in .info file no Ubercart in dependencies. But this is reaaly problem, as
in reality module Ubercart does not exist, this is only module package.
In file uc_paymill.install no need to use quotes, Coder confirms this.
to
The rest looks good.
Comment #6
aramboyajyan CreditAttribution: aramboyajyan commentedThanks for the feedback.
README.txt
as well as the project page to explicitly say "download with Drush" rather than "install with Drush" and that Ubercart won't be downloaded with Drush automatically.Comment #7
klausiReview of the 7.x-1.x branch:
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
manual review:
But that are not blockers, otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.
Assigning to patrickd as he might have time to take a final look at this.
Comment #8
aramboyajyan CreditAttribution: aramboyajyan commentedThank you very much for the review.
Automatic review comments
check_plain()
have been removed and committed.$get_active_keys
is left on purpose for developer clarity.Manual review comments
check_plain()
for recognizing Paymill response messages has been removed and committed.Comment #9
patrickd CreditAttribution: patrickd commentedomg!! so many inline comments :)
well done, I've nothing to complain about
Thanks for your contribution, topsitemakers!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #10
aramboyajyan CreditAttribution: aramboyajyan commentedHi Patrick,
Thanks for the positive feedback, updating my account and posting recommended readings :)
I hope the module will be useful for the community. I plan on contributing more projects and some of them are already being prepared.
Cheers!