Follow-up from #1653026: [META] Use properly typed values in module configuration.
Problem/Motivation
All integers, Booleans, and even octal numbers in config object files are converted to strings.
Proposed resolution
#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.
Remaining tasks
search.routing.yml ('TRUE' to TRUE)
entity.view_mode.node.search_index.yml
entity.view_mode.node.search_result.yml
search.settings.yml
search_embedded_form.settings.yml
search_extra_type.settings.yml
User interface changes
NO
API changes
NO
Related Issues
Parent: #1653026: [META] Use properly typed values in module configuration
Comment | File | Size | Author |
---|---|---|---|
#13 | 21005983-search-13.patch | 1.47 KB | vijaycs85 |
#13 | 21005983-diff-11-13.txt | 1002 bytes | vijaycs85 |
#14 | 2105983-13-search.yml_.patch | 1010 bytes | a_thakur |
#11 | 21005983-11-search-yml.patch | 1.45 KB | jhodgdon |
#4 | 21005983-2-search-yml.patch | 1.37 KB | mr.baileys |
Comments
Comment #1
jhodgdonThere is a note at the top of the meta-issue that says:
WARNING: DO NOT work on below sub-tasks until #2106459: Core config has everything as string
@chx got a better option to cover most of the sub tasks as a single issue
So I think this issue needs to be postponed for now.
Comment #2
mr.baileysSince #2106459: Core config has everything as string has landed, I assume this issue is no longer postponed?
Attached is a patch that removes the force-casting to string form search module's configuration files. Note that this excludes search.routing.yml (I assume this is not a configuration file, and removing the quotes there causes a fatal error: A fatal error occurred: Routing requirement for "_search_access" must be a string.)
Comment #3
jhodgdonThe patch is missing?
Comment #4
mr.baileysOops, sorry. Here it is.
Comment #5
jhodgdonThis doesn't look problematic, and I verified it covers all the changes we need in core/modules/search/config.
However, there are a couple of test classes in core/modules/search/test that have config, and are not covered.
Comment #6
mr.baileysThanks for the review, jhodgdon!
The only config file under
core/modules/search/tests
that contained non-strings cast to string iscore/modules/search/tests/modules/search_embedded_form/config/search_embedded_form.settings.yml
I think, and it is included in the patch in #4. Are there other config files undercore/modules/search
I missed?Comment #7
jhodgdonThat looks like it. I just saw that one and added the comment without looking to see if there were more. Thanks!
Comment #8
jhodgdon#4: 21005983-2-search-yml.patch queued for re-testing.
Comment #9
jhodgdonI just applied the patch above and confirmed there are no remaining files under core/modules/search that need to be fixed (at least, I think that's it).
I am not sure what that test failure was - random glitch? This patch should be fine.
Adding tags back that I deleted somehow in an earlier comment.
Comment #11
jhodgdonThis is a straight reroll. The above patch applied fine with fuzz.
Comment #12
alexpottThese are booleans so we should use the values
true
andfalse
here. See entity.view_mode.comment.full.ymlComment #13
vijaycs85updating as per #12. However committing #2096373: Provide config schema for View modes and running @chx script (in #2106459-7: Core config has everything as string) solves this problem globally on all view modes.
Comment #14
a_thakur CreditAttribution: a_thakur commentedUpdated patch as per comment #12
Comment #15
vijaycs85Sorry for the cross post @a_thakur, but your patch missing
Comment #16
jhodgdonAgreed. The patch in ****#13**** -- not #14 -- is good to go. Thanks!
Comment #17
alexpottCommitted c8b0a63 and pushed to 8.x. Thanks!
Comment #17.0
alexpottupdating files
Comment #19
a_thakur CreditAttribution: a_thakur as a volunteer and at Srijan | A Material+ Company commented