Part of #2072251: [meta] Modernize forms to use FormBase

Updated: Comment #N

Problem/Motivation

Now that #2059245: Add a FormBase class containing useful methods is in, I was looking at old forms that have empty validateForm() methods, or still use Drupal::service() or t().

Proposed resolution

Convert existing FormInterface forms to extend FormBase

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 modernize_search_module-2078005-1.patch13.37 KBIvan Zugec
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Ivan Zugec’s picture

Ivan Zugec CreditAttribution: Ivan Zugec commented
Assigned: Unassigned » Ivan Zugec
Status: Active » Needs review
FileSize
modernize_search_module-2078005-1.patch13.37 KB

Patch updates three forms and removes an empty validateForm().

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

This all looks very straightforward and correct. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 96edb78 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.