Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
In a clean drupal 8 (git) installation i get "Missing text format: ." watchdog message when i go to admin/config/content/formats/manage/basic_html.
The error messages are one for each format, each time i visit admin/config/content/formats/manage/
page. I tried to save without changes, the problem remains.
My box config: Apache/2.2.22 (Unix) DAV/2 PHP/5.4.15 mod_ssl/2.2.22 OpenSSL/0.9.8x, OS X 10.7.5
Comment | File | Size | Author |
---|---|---|---|
#3 | 2089599-3.patch | 919 bytes | Wim Leers |
#2 | 2089599-2.patch | 790 bytes | swentel |
Comments
Comment #1
FredericoT CreditAttribution: FredericoT commentedI did a test on a clean D8 install and noticed the same thing happening.
I looked a bit further and found that the $format_id that is being passed to the check_markup function is an empty string at the moment. Not sure what a good solution would currently be because the call to filter_fallback_format() also returns an empty string here.
Comment #2
swentel CreditAttribution: swentel commentedCould reproduce. It comes from the ckeditor module, moving to editor module component (as there's not ckeditor one)
Patch attached fixes the watchdog messages, but not sure whether this is the right solution.
Comment #3
Wim LeersNice find!
Thanks for that patch, swentel, that really helps. See the attached reroll, which I think is better.
Comment #4
swentel CreditAttribution: swentel commentedWorks for me.
Comment #5
Wim Leers.
Comment #6
webchickNo test?
Comment #7
Wim LeersThere's no point in writing a regression test for this. Note that the user was never affected by this, it was just a warning message in the watchdog logs!
Writing tests for this would be akin to adding tests for all possible paths in Drupal and checking if they didn't trigger a watchdog addition…
Comment #8
webchickOk, fair enough. :)
Committed and pushed to 8.x. Thanks!
Comment #9
Wim LeersThanks! :)