Follow-up from #2083803: Convert field type to typed data plugin for field_test module
This hook was added in #565480: TF #2: Multilingual field handling and no longer needed as parent issue shows.
Also field_test.install
file could be removed
The reason to preserve this hook was @berdir's suggestion about scope #2083803-40: Convert field type to typed data plugin for field_test module
Comment | File | Size | Author |
---|---|---|---|
#11 | 2106501-11.patch | 1.04 KB | swentel |
#8 | 2106501-8.patch | 1.74 KB | swentel |
#2 | remove_hook_install-2106501-2.patch | 602 bytes | Ivan Zugec |
Comments
Comment #1
andypostproperly tagging
Comment #2
Ivan Zugec CreditAttribution: Ivan Zugec commentedThis patch removes
field_test_install()
from field_test.install.However, based on this line, "Also field_test.install file could be removed", should we just remove "field_test.install" file?
Comment #3
Ivan Zugec CreditAttribution: Ivan Zugec commentedComment #4
BerdirThe issue will conflict which the referenced field_test issue, let's get that in first. If we don't need this anymore then we should also remove the actual implementation of the referenced hook, field_test_entity_info_alter().
Comment #5
BerdirThe referenced issue went in, so this can be re-rolled. Remember to also remove the referenced hook from field_test.module.
Comment #6
andypostThis hook is needed and used in tests.
There's just no more need in weight because
hook_entity_info_alter
infield_test.entity.inc
have no collisions with content_translation module that operates on bundle level viacontent_translation_entity_bundle_info_alter
PS: it's really interesting how content translation
content_translation_entity_info_alter()
works because it always fires beforefield_test_entity_info_alter()
... so 'translatable; entity property is not changedComment #7
andypostseems we need tag this, because
field_test_entity_info_translatable()
used inTranslationTest.php
&TranslationWebTest.php
Comment #8
swentel CreditAttribution: swentel commentedLet's see what this gives now.
Comment #10
andypostas I said this needed because this code initializes 'translatable' for entities
Comment #11
swentel CreditAttribution: swentel commentedOk, let's see what this gives then :)
Comment #12
BerdirHm, ok. #2019055: Switch from field-level language fallback to entity-level language fallback will change how that stuff works and replaces those tests with new ones I think. So by then, it will probably not be used anymore. We should then either simply remove it there or postpone it on that issue, I think?
Comment #13
andypostNo reason to postpone. The scope of the issue to clean-up install
Comment #14
Xano#11: 2106501-11.patch queued for re-testing.
Comment #15
webchickNice find!
Committed and pushed to 8.x. Thanks!