Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
1. Enable the following modules: taxonomy, synonym, term_merge, taxonomy_manager
2. Create a vocabulary with the "Default synonyms field" option checked.
3. Create some terms in the vocabulary.
4. Note the options available when merging terms using the taxonomy module: /admin/structure/taxonomy/{vocabulary_machine_name}/merge
These options need to be available when merging terms using the taxonomy manager module.
Comment | File | Size | Author |
---|---|---|---|
#3 | taxonomy_manager-term_merge_options-2075133-1.patch | 3.29 KB | Anonymous (not verified) |
#2 | 2075133-term_merge_options-2.patch | 3.29 KB | bucefal91 |
#1 | taxonomy_manager-term_merge_options-2075133-1.patch | 1.94 KB | Anonymous (not verified) |
Comments
Comment #0.0
Anonymous (not verified) CreditAttribution: Anonymous commentedUpdate description
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedpatch is attached
Comment #2
bucefal91 CreditAttribution: bucefal91 commentedHello,
I am the current maintainer of Term Merge module. I wanted just to slightly correct the patch provided by SpaJenniOs. I intended to provide 2 functions for merge options. One to generate form elements that represent merge options.
term_merge_merge_options_elements()
- this one. SpaJenniOs, you got this one in your patch. But i also provide another function to collect the submitted values from those form elements so you don't have to know the real form structure behind those settings. The function for collecting submitted values isterm_merge_merge_options_submit()
. Output of this function is supposed to go directly intoterm_merge($selected_tids, $dest_term->tid, __HERE__);
On a different note, due to a pitty error in naming convensions in Term Merge releases, there exists 7.x-2.0-beta2 version, which in fact was intented to be 7.x-1.0-beta2 and it is quite behind in features from the current 7.x-1.x-dev. but there are people using it. https://drupal.org/project/usage/term_merge - around 600 people. And I can't enforce them to switch to another version because "officially" 7.x-2.0-beta2 is "higher" than 7.x-1.0, so I added a couple of exceptions for the case when Term Merge is in that ill-lucked 7.x-2.0-beta2 version. I tried to run a really simple term merge from Taxonomy Merge interface with the patched code and it worked for me.
By the way, you can find a more detailed description of merge options on the documentation of Term Merge module: https://drupal.org/node/2074695
I am switching to 7.x-1.x-dev version of this issue because my patch goes against the dev snapshot. Heh, hopefully it helps, I'd be glad to see Taxonomy manager incorporating the merge settings from Term merge module :)
Comment #3
Anonymous (not verified) CreditAttribution: Anonymous commented@bucefal91 Thank you for your input! I tested the patch "2075133-term_merge_options-2.patch" with the following versions and it works for me.
Drupal 7.23
Taxonomy Manager 7.x-1.0+0-dev
Term Merge 7.x-1.0
I updated my patch for 7.x-1.0 (attached) to use until this patch on dev goes live.
Comment #4
apotek CreditAttribution: apotek commentedThis patch does what it says on the label. If I were the maintainer, I would probably prefer to commit a patch that was targeting release versions of interacting modules, and dev versions of the taxonomy_manager module, but nevertheless, the patch is solid and fixes a huge hole in taxonomy_manager functionality.
Is there any way this patch can be rolled to trigger testing? I want to mark this issue RTBC, but feel like I want to see it pass tests too.
Comment #4.0
apotek CreditAttribution: apotek commentedUpdate description
Comment #5
Anonymous (not verified) CreditAttribution: Anonymous commentedBump. Any chance we can get some eyes on this?
Comment #6
dillix CreditAttribution: dillix commentedIt worked for me too, so RTBC it.
Comment #7
VladimirAusCan not apply to the latest dev.
Is that still an issue?