Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Background:
This issue is part of the task to update the hook_help texts of the Drupal 8 modules:
#1908570: [meta] Update or create hook_help() texts for D8 core modules
Tasks:
- review / write the hook_help text according to help guidelines
Comment | File | Size | Author |
---|---|---|---|
#5 | syslog-help-text-2091425-5.patch | 2.12 KB | ifrik |
#5 | interdiff-2091425-4-5.txt | 2.12 KB | ifrik |
#4 | syslog-help-text-2091425-4.patch | 2.08 KB | batigolix |
#2 | syslog-help-text-2091425-1.patch | 2.08 KB | wzoom |
Comments
Comment #1
wzoom CreditAttribution: wzoom commentedI am working on the documentation.
Comment #2
wzoom CreditAttribution: wzoom commentedComment #3
jhodgdonThanks for the patch, and sorry for the delay in reviewing this patch -- the help sprint was so successful, I have been having trouble catching up!
The change from double to single quotes here is not wanted. Our coding standards say that if there are apostrophes in text, you should enclose it in double quotes. So can you put that back?
Other than that, looks good!
Comment #4
batigolixpatch reverts quotes and changes http to https in link to d.o.
Comment #5
ifrikI've changed the sentence "For more info..." in the about section according to the Help text standard, and made the reference to the php documentation pages a bit clearer.
Comment #6
batigolixchanging component for maintainers feedback, if any
Comment #7
jhodgdonSlip of the finger - here's the right component. :)
Actually though, since we are not changing the help text for this module, I don't even know if we need a review by the maintainers. However, it can't hurt.
These changes seem to be fine and I'll tentatively set this to RTBC.
Comment #8
jhodgdonI decided to just go ahead and commit this, since it is just a standards update. Thanks all!