Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I wanted to propose this small patch to rename all cache prefixes in the same way. This discussion was started in the following ticketSearchPluginManager plugin definitions aren't cached and I thought it was nice to have something consistent between them.
Any suggestion is more than welcome on either include other files I missed or leave some of them I patched alone for a specific reason currently unknown to me.
Comment | File | Size | Author |
---|---|---|---|
#7 | plugins_cache_prefixes_name_convention_consistency-3.patch | 13.13 KB | Bladedu |
#7 | interdiff.txt | 1.3 KB | Bladedu |
#3 | plugins_cache_prefixes_name_convention_consistency-2.patch | 13.1 KB | Bladedu |
#3 | interdiff.txt | 599 bytes | Bladedu |
plugins_cache_prefixes_name_convention_consistency.patch | 12.4 KB | Bladedu | |
Comments
Comment #1
dawehnerI do like the _plugins suffix as it makes it clear that this is about the plugin information.
Is there a reason why this hunk in LocalTaskManager was not changed?
You could argue that the local task manager stores more than just the local task plugin information as it also stores information by route.
Comment #2
BladeduGood remark and I agree with you that localManager should also be included. I will reroll the previous patch including the missing plugin managers.
Thanks for the review :)
Comment #3
BladeduIncluded LocalTaskManager to the list of renamed cache prefixes.
For the config_translation module, I'll propose a patch to its project issue list.
Comment #4
dawehnerGreat, thank you!
Comment #5
catch#3: plugins_cache_prefixes_name_convention_consistency-2.patch queued for re-testing.
Comment #7
BladeduRe-rolled patch. ImageToolkitManager was moved from system module to ImageToolkit module.
Comment #8
pfrenssenExcellent, thanks! Back to RTBC.
Comment #9
catchCommitted/pushed to 8.x, thanks!