Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/dblog/lib/Drupal/dblog/Tests/DbLogTest.php

Line 314: Unused local variable $langcode
Line 501: Unused local variable $key

CommentFileSizeAuthor
#3 drupal-core-remove-unused-local-variable-2080561-3.patch663 bytesmrsinguyen
#1 drupal-core-remove-unused-local-variable-2080561.patch1.04 KBmrsinguyen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mrsinguyen’s picture

mrsinguyen CreditAttribution: mrsinguyen commented
Status: Active » Needs review
FileSize
drupal-core-remove-unused-local-variable-2080561.patch1.04 KB
rhm5000’s picture

rhm5000 CreditAttribution: rhm5000 commented
Status: Needs review » Needs work

Patch no longer applies.

$ git apply --index drupal-core-remove-unused-local-variable-2080561.patch
error: patch failed: core/modules/dblog/lib/Drupal/dblog/Tests/DbLogTest.php:312
error: core/modules/dblog/lib/Drupal/dblog/Tests/DbLogTest.php: patch does not apply
mrsinguyen’s picture

mrsinguyen CreditAttribution: mrsinguyen commented
Status: Needs work » Needs review
FileSize
drupal-core-remove-unused-local-variable-2080561-3.patch663 bytes
rhm5000’s picture

rhm5000 CreditAttribution: rhm5000 commented
Status: Needs review » Reviewed & tested by the community

Patch applies and removes unused variable $key, $langcode variable no-longer in DbLogTest.php.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Title: Remove Unused local variable $langcode from /core/modules/dblog/lib/Drupal/dblog/Tests/DbLogTest.php » Remove Unused local variable from /core/modules/dblog/lib/Drupal/dblog/Tests/DbLogTest.php
Status: Reviewed & tested by the community » Fixed

Committed ef02f36 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.