Updated: Comment #6

Problem/Motivation

Currently, the module name and setting name are inconsistent for HTTP Basic auth. We should make them consistent.

Proposed resolution

Change basic_auth module's authentication provider name to basic_auth, so that it is consistent.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

linclark’s picture

Issue tags: +Novice

This should be relatively simple, adding Novice tag.

StephaneQ’s picture

Status: Active » Needs review
FileSize
4.4 KB
klausi’s picture

Status: Needs review » Reviewed & tested by the community

I wonder if people will be confused and search for HTTP basics in this module, like the Symfony HTTP foundation component.

I think basic_auth is more clear that this is an authentication provider, maybe we should change it the other way around and make everything basic_auth? Any objections against that?

klausi’s picture

Status: Reviewed & tested by the community » Needs review

Oops, didn't mean to change the status.

linclark’s picture

I personally don't think it would be a problem, but I'm not opposed to changing it to basic_auth either.

klausi’s picture

Status: Needs review » Needs work

We agreed on the last REST call to rather go with basic_auth everywhere.

@StephaneQ care to roll a patch for that?

StephaneQ’s picture

Status: Needs work » Needs review
FileSize
6.41 KB
tstoeckler’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 83e1359 and pushed to 8.x. Thanks!

alexpott’s picture

Issue summary: View changes

go with basic_auth everywhere

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.