Hey I noticed that we're not using the freshest SymfonyCMF Routing component. I was using composer to test some other things and when I did a composer update it updated a whole bunch of things that were out of date. One of them was Routing and here's the patch that brings it up to date.

CommentFileSizeAuthor
#5 UpdateSymfonyCMF.patch140.21 KBcosmicdreams
RoutingUpdates.patch15.9 KBcosmicdreams
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams commented
Status: Active » Needs review
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Component: documentation » routing system

Not a documentation issue.

cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams commented
Status: Needs review » Needs work

Need to doublecheck that I did this patch right. A number of patches I submitted like this only included additions to the component. I'll do this again.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

It is hard to imagine that this is right as the composer file nor the composer lock file was touched by this patch.

cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams commented
Title: Updated Symfony CMF's Routing Component » Updated Symfony CMF's Routing Component to v1.1.0
Status: Needs work » Needs review
FileSize
UpdateSymfonyCMF.patch140.21 KB

OK, I've redid the update to SymfonyCMF Routing 1.1.0 and test Drupal's installation process. Here's the full update.

Crell’s picture

Crell CreditAttribution: Crell commented
Status: Needs review » Reviewed & tested by the community

Okie day.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented 
+++ b/core/vendor/autoload.php
index 1db8d9a..bcf9809 100644
--- a/core/vendor/composer/ClassLoader.php

--- a/core/vendor/composer/ClassLoader.php
+++ b/core/vendor/composer/ClassLoader.php

+++ b/core/vendor/composer/ClassLoader.php
+++ b/core/vendor/composer/ClassLoader.php
@@ -49,7 +49,7 @@ class ClassLoader

@@ -49,7 +49,7 @@ class ClassLoader
 
     public function getPrefixes()
     {
-        return call_user_func_array('array_merge', $this->prefixes);
+        return $this->prefixes;
     }

It is a bit odd that there are so many changes in ClassLoader.php . Can someone just have a look whether they are okay?

cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams commented

I just did the standard:

php composer.phar update symfony-cmf/routing

update procedure. Is that the right way to do it?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

I don't know, it just felt wrong. Maybe you had an older/newer version of composer which caused that. I will ask some people later.

cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams commented

newer, I was prompted to update my composer so I did 5 days ago.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated issue summary.