Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Unit test for the Drupal\serialization\Normalizer\ListNormalizer class.
Related to #2082735: Unit test Drupal\serialization\Normalizer\TypedDataNormalizer class
Comment | File | Size | Author |
---|---|---|---|
#11 | 2083175-11.patch | 1.88 KB | damiankloip |
#11 | interdiff-2083175-11.txt | 982 bytes | damiankloip |
#6 | 2083175-6.patch | 1.46 KB | damiankloip |
d8.ListNormalizerTest.patch | 3.27 KB | damiankloip | |
Comments
Comment #1
dawehnerPerfect
Comment #2
webchickCommitted and pushed to 8.x. Thanks!
Comment #4
linclark CreditAttribution: linclark commentedIt looks like there are some copy/paste issues with this test.
Comment #5
linclark CreditAttribution: linclark commentedAlso, it would be nice to have some comments in the setUp().
Comment #6
damiankloip CreditAttribution: damiankloip commentedComment #7
linclark CreditAttribution: linclark commentedShould the @group be Drupal? It looked like it was specific to the package in other tests.
Comment #8
linclark CreditAttribution: linclark commentedAlso, the getInfo method needs to be switched from TypedData to List.
Comment #9
dawehnerYeah this would be great to add.
Comment #10
linclark CreditAttribution: linclark commentedComment #11
damiankloip CreditAttribution: damiankloip commentedFair, how about...
Comment #12
dawehnerI should have reviewed it with more clarity.
Comment #13
catchCommitted/pushed to 8.x, thanks!
Comment #14.0
(not verified) CreditAttribution: commentedUpdated issue summary.