Allows the SMS Framework to use phps.kr as a gateway.
Currently only basic sms sending functionality is implemented.
Rules integration is available thanks to SMS framework module.
I just changed project name from SMS PHPSKR to phpskr.
To do:
Check balance and notify shortage to admin user.
Requirement:
Account of korean sms gateway service provider, phps.kr
Dependencies:
SMS Framework
Project page
https://drupal.org/sandbox/mozolady/2092981
GIT
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/mozolady/2092981.git phpskr
PAReview.sh results
All errors and warnings have been fixed.
http://pareview.sh/pareview/httpgitdrupalorgsandboxmozolady2092981git-7x-1x
Sponsored By:
This module is being sponsored by: Next Aeon Inc - a Korean Drupal Shop since 2009
Comments
Comment #1
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxmozolady2092981git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
mozodev CreditAttribution: mozodev commentedFix the errors and notices listed on the automated review.
Comment #2.0
mozodev CreditAttribution: mozodev commentedproject name & some info updated
Comment #3
gyuhyon CreditAttribution: gyuhyon commentedTested it and send a sms msg as described
Comment #4
gyuhyon CreditAttribution: gyuhyon commentedworking as described.
Comment #5
gyuhyon CreditAttribution: gyuhyon commentedsorry , i was not familiar with the issue queue terms.
this module works as designed for basic function.
Comment #6
klausiThis is the correct status, see https://drupal.org/node/532400
Comment #7
kscheirer'msg' => 'test',
in sms_phpskr_command() ?case 'getbalance':
is that intentional?----
Top Shelf Modules - Crafted, Curated, Contributed.
Comment #8
mozodev CreditAttribution: mozodev commentedThanks for your review!
Comment #9
Rade CreditAttribution: Rade commentedManual review (reading through files, functionality not tested):
Otherwise seemed pretty much okay.
Comment #10
klausiThat minor issue is surely not an application blocker, anything else? (RTBC is the correct status if you could no find blockers)
Comment #11
mozodev CreditAttribution: mozodev commentedRemoved empty line at the beginning and polished some code and add some comments to README.txt.. thanks.
Comment #11.0
mozodev CreditAttribution: mozodev commentedadded sponsorship ^^
Comment #12
AjitSTwo weeks, no review. Changing the priority of the status to Major. I'd suggest you to apply for the Review Bonus so that this issue gets more attention, and someone will look at it right away.
Comment #13
kscheirerYou have an unused variable $authkey in sms_phpskr_admin_form(). Could not find any other problems. Pareview's complaint about form_state['input'] is spurious, the value is only being checked, not used.
Comment #14
kscheirerIt's been a month without any problems reported, so I'm promoting this myself as per https://drupal.org/node/1125818.
Thanks for your contribution, mozodev!
I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
----
Top Shelf Modules - Crafted, Curated, Contributed.
Comment #15
mozodev CreditAttribution: mozodev commentedThanks you all~