Follow-up from #2050821: Add larowlan as a component maintainer for comment.module.

Based on:

#731724: Convert comment settings into a field to make them work with CMI and non-node entities
https://drupal.org/project/issues/search/drupal?participant=andypost&ver...
Volunteered in #2050477: [META] Identify component maintainers for components with no maintainer listed in MAINTAINERS.txt

roadmap #1847540-4: [META] Clean up comment module tests and decouple from node

PS: once d8 accept the comments field I'm responsive

CommentFileSizeAuthor
#3 drupal8.comment-module.2099977-3.patch392 bytesandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Title: Add larowlan as a component maintainer for comment.module » Add andypost as a component maintainer for comment.module

Sorry, now need some sleep

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes

roadmap

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Reviewed & tested by the community

As comment module was basically rewritten by him and larowlan there is no reason to not put him into it!

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Reviewed & tested by the community » Needs review
FileSize
drupal8.comment-module.2099977-3.patch392 bytes

Patch as always... and testing (suppose no re-rolls will be needed)

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Reviewed & tested by the community

RTBC ^ 10000

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented

+100500 RTBC )))

dixon_’s picture

dixon_
he/him
Primary language English
Location France
CreditAttribution: dixon_ commented

Sounds like a good idea to me

Chi’s picture

Chi CreditAttribution: Chi commented

RTBC for me as well

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Assigned: larowlan » Unassigned

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

comment link