Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
We need to make it more obvious how to update issue summary, now that it's not possible to do via comment form as before.
Remaining tasks
Add 'Update this issue' link next to the comment form.
Comment | File | Size | Author |
---|---|---|---|
#13 | Comment_form_update_link.png | 18.92 KB | jthorson |
#11 | 2097927_bluecheese_Add-update-issue-link-to-comment-form.patch | 1.08 KB | jthorson |
#11 | 2097927_drupalorg_Add-update-issue-link-to-comment-form.patch | 1.88 KB | jthorson |
#9 | rage-fixed.png | 114.41 KB | tvn |
_001.png | 51.66 KB | andypost |
Comments
Comment #1
Bojhan CreditAttribution: Bojhan commentedNo, this is actually by design - click the huge Update this issue.
Comment #2
jthorson CreditAttribution: jthorson commentedPositioning as a feature request, and tagging for discussion.
Comment #3
andypostAt least comment body needs more rows by default
Comment #4
jthorson CreditAttribution: jthorson commentedComment #5
tvn CreditAttribution: tvn commentedClosed #2098091: There *must* be a way to easily update an issue from the comment form. as duplicate of this one.
Our options include:
1. Make 'issue details' block sticky
2. Repeat 'issue details' block at the bottom (which will look ugly when both blocks are visible on the screen e.g. when there are no comments)
3. Add 'Update this issue' link next to the comment form.
Comment #5.0
tvn CreditAttribution: tvn commentedupd
Comment #6
jthorson CreditAttribution: jthorson commentedI think the motivation behind this issue was to put the 'full' edit issue form (complete with metadata and file upload) on the issue page itself instead of behind another mouse click ... not simply moving/duplicating the 'update this issue' button.
Comment #7
tvn CreditAttribution: tvn commentedIn that case it should've been closed as (works as designed) after the first comment. We still need to make it more obvious how to update issues now, so let's continue here instead of closing this issue and re-opening the other one.
Comment #7.0
tvn CreditAttribution: tvn commentedimg
Comment #8
tvn CreditAttribution: tvn commentedDuring D7 team call today we settled on adding "Update this issue" link next to the comment form. Changing title accordingly.
Comment #8.0
tvn CreditAttribution: tvn commented.
Comment #9
tvn CreditAttribution: tvn commentedMockup:
Or we could even have 2 different links - Update this issue and Upload new file.
It might be not too obvious that one needs to update an issue in order to upload a file. On the other hand less links, less choices to make.
Comment #10
jthorson CreditAttribution: jthorson commentedComment #11
jthorson CreditAttribution: jthorson commentedOkay ... this took a couple steps, since the 'Add this comment' is hard-coded directly within the comment-wrapper template.
The Bluecheese patch modifies this to output $variables['comment_form_title'] in the template, and defines this as the default 'Add new comment' text within bluecheese_preprocess_comment_wrapper().
The drupalorg patch then sets it's own $variables['comment_form_title'] value, adding the 'Update this issue' link within it's own preprocess_comment_wrapper() call.
Comment #12
jthorson CreditAttribution: jthorson commentedComment #13
jthorson CreditAttribution: jthorson commentedScreenshot from dev site, with patches applied.
Comment #14
helmo CreditAttribution: helmo commented+1, looks better
Comment #15
drummI'm not too fond of making any PHP additions in bluecheese, but this is temporary. Committed & deploying.
Comment #16
drummForgot to untag. We're not really in a hurry, so this isn't even Drupal.org 7.1.
In the meantime, we can think about:
Comment #17
jthorson CreditAttribution: jthorson commentedYeah ... the bluecheese template was a bit of a head-scratcher. But even more so is the fact that this can't be over-ridden any other way in core ... the text for this title is hard-wired into the .tpl file, whereas we make just about everything else alter-able via hooks.
Comment #17.0
jthorson CreditAttribution: jthorson commentedupd
Comment #18
mgiffordI think this issue needs to be updated.
Can we close this issue and create follow-up issues for the Google Analytics? Would be great to have stats on what folks are actually doing.
I like the idea about pointing to new UI changes in drupal.org. But again that should be a new issue.
Comment #19
drummThis was rolled into #2159813: Display parts of the issue edit form instead of the comment form on issue pages.