Complete config of Contact module [#2105927]

Follow-up from #1653026: [META] Use properly typed values in module configuration.

Problem/Motivation

1. There is no 'status' and 'langcode' elements in contact.category.*.yml
2. contact.settings.user_default_enabled become 1 in active dir whereas module has true
3. views.view.test_contact_link.yml has type casting.

Proposed resolution

Fix them in the list

Remaining tasks

Fix and issue patch.

User interface changes

API changes

Parent: #1653026: [META] Use properly typed values in module configuration

Comment	File	Size	Author
#5	contact_config-2105927-5.patch	5.35 KB	a_thakur
#5
#3	contact_config-2105927-3.patch	5.11 KB	a_thakur
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

a_thakur CreditAttribution: a_thakur commented 21 October 2013 at 15:01

Status:

Active

» Reviewed & tested by the community

Went through the following files and could not find any such occurrence of integers, Booleans, octal numbers in config object files as strings.

contact.category.feedback.yml
contact.category.personal.yml
contact.settings.yml
views.view.test_contact_link.yml

Changing to reviewed & tested by community

Comment #2

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 21 October 2013 at 18:15

Title:	Make sure all YML files in Contact module has no type-casting to string.	» Complete config of Contact module
Status:	Reviewed & tested by the community	» Needs work

yeah, we don't have type casting, but we do miss few element on default config. Updating issue summary/title to reflect the new scope of this issue.

1. There is no status and language elements in contact.category.*.yml
2. contact.settings.user_default_enabled become 1 in active dir whereas module has true
3. views.view.test_contact_link.yml has lots of integer in quotes

Comment #3

a_thakur CreditAttribution: a_thakur commented 22 October 2013 at 04:31

Status:

Needs work

» Needs review

File	Size
contact_config-2105927-3.patch	5.11 KB

Fixed the following, please review

Added status and language elements in contact.category.*.yml
contact.settings.user_default_enabled become 1 in active dir whereas module has true
Removed quotes for integers in views.view.test_contact_link.yml.

Comment #3.0

a_thakur CreditAttribution: a_thakur commented 22 October 2013 at 04:31

Issue summary:

View changes

Updated issue summary.

Comment #4

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 24 November 2013 at 23:01

Issue summary:	View changes
Status:	Needs review	» Needs work

+++ b/core/modules/contact/tests/modules/contact_test_views/test_views/views.view.test_contact_link.yml
@@ -2,13 +2,13 @@ base_field: uid
+status: 1

should be true.

+++ b/core/modules/contact/tests/modules/contact_test_views/test_views/views.view.test_contact_link.yml
@@ -21,42 +21,42 @@ display:
+          slave: 0
...
...
...

all boolean values should be true/false.