This module adds a basic line item type to Drupal Commerce. This line item type should be used by admins to add arbitrary price amounts directly to orders without needing the use of products. e.g. Adding a payment order to a user account manually after the user paid in person. I could not find a similar project, but I might have missed one if it exists.

This module also updates the Commerce Line Item view to display the added amounts to the table.

Project page: https://drupal.org/sandbox/TylerPepper/2093967
git clone --branch master TylerPepper@git.drupal.org:sandbox/TylerPepper/2093967.git

Comments

PA robot’s picture

PA robot CreditAttribution: PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxTylerPepper2093967git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Tyler the Creator’s picture

Tyler the Creator CreditAttribution: Tyler the Creator commented
Status: Needs work » Needs review

Fixed all the errors that I could from the review tools. The views handler code could not be changed.

Removed master branch and set up version branch instead.

jmking’s picture

jmking CreditAttribution: jmking commented
Status: Needs review » Reviewed & tested by the community

I see you've created your release branch and tag already, so all's good on my end.

The code sniffer complaints seem to be things you can't change as they are method naming conventions imposed by Commerce.

PaulDinelle’s picture

PaulDinelle CreditAttribution: PaulDinelle commented

Agreed that the errors are method naming conventions from Commerce, so nothing to do there. Commenting conventions look reasonable, as well.

mcgowanm’s picture

mcgowanm CreditAttribution: mcgowanm commented

Tested in my local sandbox environment and it looks great. I agree with jmking, most of the PA robot's complaints are unavoidable for a Commerce dependent module.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
CreditAttribution: kscheirer commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

In commerce_basic_line_item_title(), use drupal_ucfirst(), it's multi-byte safe.

The module seems fine, but this functionality seems like it would be better suited to an existing contrib module or commerce line item.

Possible Duplication
It seems that Commerce Custom Line Items provides very similar functionality. Could you describe how your module differs?

We prefer collaboration over competition, therefore we want to prevent having duplicating modules on drupal.org. If the differences between these modules are not too fundamental for patching the existing one, we would love to see you joining forces and concentrate all power on enhancing one module. (If the existing module is abandoned, please think about taking it over).

If that fails for whatever reason please get back to us and set this back to "rtbc".

----
Top Shelf Modules - Crafted, Curated, Contributed.

jmking’s picture

jmking CreditAttribution: jmking commented

@kscheirer

Commerce Custom Line Items doesn't have a stable release and is unsupported in favour of a different project (Commerce Customizable Products) that still relies on products to work. This module is for administrators to add entirely arbitrary line items to an admin created order that aren't tracked as products.

Tyler the Creator’s picture

Tyler the Creator CreditAttribution: Tyler the Creator commented
Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

Committed the fix to use drupal_ucfirst() in commerce_basic_line_item_title().

As jmking mentioned, Commerce Custom Line Items didn't fit what I needed for a project when I created this module. I looked around for a solution to an admin (or someone with commerce store permissions) needing to add any price amount to an order as a line item and found this: thread. I saw the top response and decided to make my own module and contribute it back to the community.

It is a very basic, light weight module that fits a specific need in Commerce. If there's another project that I can add this functionality to I would gladly contribute.

Thanks for taking a look.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
CreditAttribution: kscheirer commented
Status: Reviewed & tested by the community » Fixed

It's been a month without any problems reported, so I'm promoting this myself as per https://drupal.org/node/1125818.

Thanks for your contribution, Tyler Pepper!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.