Clean up Views join plugins [#2105425]

Part of #2096783: [META] Clean up Views plugin classes.

Comment	File	Size	Author
#2	2105425-2.patch	4.27 KB	damiankloip
#2
#2	interdiff-2105425-2.txt	1.12 KB	damiankloip
	vdc.join-tidy.patch	4.28 KB	damiankloip

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

dawehner

German

CreditAttribution: dawehner commented 6 October 2013 at 00:09

Status:

Needs review

» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/join/JoinPluginBase.php
@@ -46,8 +46,6 @@
- * @todo It might make sense to create an interface for joins.
- *
  * Extensions of this class can be used to create more interesting joins.

Note for other people: we decided that view is not in the state of support it.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/join/Subquery.php
@@ -2,19 +2,18 @@
+ *   same as Drupal\views\Plugin\views\join\JoinPluginBase, except:

Should this have a starting "\"?

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/join/Subquery.php
@@ -31,16 +30,14 @@ public function __construct(array $configuration, $plugin_id, array $plugin_defi
+   * @param @param \Drupal\views\Plugin\views\query\QueryPluginBase $view_query

@param @param @param @paaaaaaaram